Manabie Challenge: Mana Do task for Frontend Engineer applicants #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate todo status; updated actions, added deleteTodo function in todoPage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roberch Ryan Simbajon: Applicant: Frontend Engineer - Submitted (April 29, 2022)
Accomplished Tasks:
Update of todo status
Deleting of todo status
Fixed a bug when adding task, it doubled upon enter
LocalStorage implementation
How to run tests:
npm i (install first dependencies used)
yarn start:frontend
Things to add if given more time:
Improve UI design, enhancements of layout, appearance, user ergonomics in interactive such web app
Improve more in TypeScript implementions, coding standards(it's my first time to use TypeScript, learn and exam in the same time, I want to learn more in this platform, so while learning TypeScript, I just applied my learning concepts from React.js, which is very challenging in my part.)