Included option for yield reduction due to land degradation

[pvjeetze]

🐦 Description of this PR 🐦

• This PR adds the option to include yield reduction through land degradation during model runs

🔧 Checklist for PR creator 🔧

• Label pull request from the label list.

  • Low risk: Simple bugfixes (missing files, updated documentation, typos) or changes in start or output scripts
  • Medium risk: Uncritical changes in the model core (e.g. moderate modifications in non-default realizations)
  • High risk: Critical changes in model core or default settings (e.g. changing a model default or adjusting a core mechanic in the model)

• Self-review own code

  • No hard coded numbers and cluster/country/region names.
  • The new code doesn't contain declared but unused parameters or variables.
  • magpie4 R library has been updated accordingly and backwards compatible where necessary.
  • scenario_config.csv has been updated accordingly (important if default.cfg has been updated)

• Document changes

  • Add changes to CHANGELOG.md
  • Where relevant, put In-code documentation comments
  • Properly address updates in interfaces in the module documentations
  • run goxygen::goxygen() and verify the modified code is properly documented

• Perform test runs

  • Low risk:
    • Run a compilation check via Rscript start.R --> "compilation check"
  • Medium risk:
    • Run test runs via Rscript start.R --> "test runs"
    • Check logs for errors/warnings
  • High risk:
    • Run test runs via Rscript start.R --> "test runs"
    • Check logs for errors/warnings
    • Default run from the PR target branch for comparison
    • Provide relevant comparison plots (land-use, emissions, food prices, land-use intensity,...)

📉 Performance changes 📈

• Current develop branch default : ** mins
• This PR's default : ** mins

🚨 Checklist for reviewer 🚨

• PR is labeled correctly
• Code changes look reasonable
  • No hard coded numbers and cluster/country/region names.
  • No unnecessary increase in module interfaces
  • model behavior/performance is satisfactory.
• Changes are properly documented
  • CHANGELOG is updated correctly
  • Updates in interfaces have been properly addressed in the module documentations
  • In-code documentation looks appropriate
• content review done (at least 1)
• RSE review done (at least 1)

[mishkos]

very good, thanks!

[flohump]

Looks good.

[pvjeetze]

I just rewrote parts of the code to account for the pollination dependency of crop types. Also the reporting of yield relevant NCP (soil intactness and pollination sufficiency) has been simplified. The file ./modules/14_yields/input/f14_yld_ncp_report.cs3 now reports a share of intact NCP per cluster. 1 means that yield-relevant NCPs are fully intact, while 0 means they have degraded. A value of 0.5 would therefore, for example, mean that 50% of yield relevant NCP per cluster have degraded.

[mishkos]

great, thanx!

[tscheypidi]

don't write the value of the scalar in the description

[pvjeetze]

Thanks for spotting this! This was changed