Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hdf5: Fix build with Sonoma/CLT 15.0 #20553

Closed
wants to merge 3 commits into from
Closed

hdf5: Fix build with Sonoma/CLT 15.0 #20553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
456fcb6
hdf5: Fix build with CLT 15.0
Dave-Allured Sep 23, 2023
28337b2
hdf5: Fix build with CLT 15.0
Dave-Allured Sep 23, 2023
2f1efa5
hdf5: Fix build with CLT 15.0
Dave-Allured Sep 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion science/hdf5/Portfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ use_bzip2 yes
depends_lib port:zlib port:libaec
use_parallel_build yes

patchfiles patch-tools-src-misc-h5cc.in.diff
patchfiles patch-no-commons.diff \
patch-tools-src-misc-h5cc.in.diff

# llvm-gcc-4.2 produced code fails type conversion tests
# Upstream suggestion is use -O0. Clang-produced code passes all tests.
Expand Down
17 changes: 17 additions & 0 deletions science/hdf5/files/patch-no-commons.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
--- configure.orig 2023-08-10 16:57:56.000000000 -0600
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a link jn fhe patchfile to the upstream commit/PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. See corrected PR #20572.

+++ configure 2023-09-22 23:08:25.000000000 -0600
@@ -11228,14 +11228,6 @@
{ printf "%s\n" "$as_me:${as_lineno-$LINENO}: checking if shared Fortran libraries are supported" >&5
printf %s "checking if shared Fortran libraries are supported... " >&6; }
H5_FORTRAN_SHARED="yes"
- ## tell libtool to do the right thing with COMMON symbols, this fixes
- ## corrupt values with COMMON and EQUIVALENCE when building shared
- ## Fortran libraries on OSX with gnu and Intel compilers (HDFFV-2772).
- case "`uname`" in
- Darwin*)
- H5_LDFLAGS="$H5_LDFLAGS -Wl,-commons,use_dylibs"
- ;;
- esac

## Report results of check(s)