Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hdf5: Fix build with Sonoma/CLT 15.0 #20553

Closed
wants to merge 3 commits into from

Conversation

Dave-Allured
Copy link
Contributor

Description

  • Remove -commons from configure, not supported in Sonoma/CLT 15.0.
  • -commons no longer needed for HDF5 series 10.0 and later.

Closes: https://trac.macports.org/ticket/68194
Was fixed upstream: HDFGroup/hdf5#3581

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

CI only
macOS 11, 12, 13, x86_64 only

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

.

Closes: https://trac.macports.org/ticket/68194

* Remove `-commons` from configure, not supported in Sonoma/CLT 15.0.
* `-commons` no longer needed for HDF5 series 10.0 and later.

Was fixed upstream:  HDFGroup/hdf5#3581
.

Closes: https://trac.macports.org/ticket/68194

* Remove `-commons` from configure, not supported in Sonoma/CLT 15.0.
* `-commons` no longer needed for HDF5 series 10.0 and later.

Was fixed upstream:  HDFGroup/hdf5#3581
.

Closes: https://trac.macports.org/ticket/68194

* Remove `-commons` from configure, not supported in Sonoma/CLT 15.0.
* `-commons` no longer needed for HDF5 series 10.0 and later.

Was fixed upstream:  HDFGroup/hdf5#3581
@macportsbot
Copy link

Notifying maintainers:
@eborisch for port hdf5.

@macportsbot macportsbot added type: bugfix maintainer: open Affects an openmaintainer port labels Sep 23, 2023
@reneeotten
Copy link
Contributor

there should be only one commit for this; instead of adding mew ones when making a change, please amend the original commit instead.

@@ -0,0 +1,17 @@
--- configure.orig 2023-08-10 16:57:56.000000000 -0600
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a link jn fhe patchfile to the upstream commit/PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. See corrected PR #20572.

@ryandesign
Copy link
Contributor

Was fixed upstream: HDFGroup/hdf5#3581

Was submitted to upstream but has not yet been accepted.

there should be only one commit for this; instead of adding mew ones when making a change, please amend the original commit instead.

It's no problem for us to fix this when merging, by using the "Squash and merge" button and rewriting the commit message.

@reneeotten
Copy link
Contributor

It's no problem for us to fix this when merging, by using the "Squash and merge" button and rewriting the commit message.

Sure, everything can be fixed but ideally regular contributors should be aware of this and take of it themselves.

@Dave-Allured
Copy link
Contributor Author

It's no problem for us to fix this when merging, by using the "Squash and merge" button and rewriting the commit message.

Sure, everything can be fixed but ideally regular contributors should be aware of this and take of it themselves.

Agreed. However, github.com does not provide normal squash or merge capability, and I am avoiding git for security. The best I can do is to move to a new branch, and make a single, cleaned-up commit.

@Dave-Allured
Copy link
Contributor Author

The best I can do is to move to a new branch, and make a single, cleaned-up commit.

Um, github.com does not support files in more than one directory in a single commit. I will have to make one commit for the portfile, and another for the patch file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: bugfix
Development

Successfully merging this pull request may close these issues.

5 participants