Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI #15

Merged
merged 3 commits into from
Feb 21, 2023
Merged

Add CI #15

merged 3 commits into from
Feb 21, 2023
+88 −0

Conversation

jatkinson1000
Copy link
Member

@jatkinson1000 jatkinson1000 commented Feb 20, 2023 •
edited
Loading

CI workflow

  • format with black
  • lint with pylint
  • run mypy
  • use pydocstyle with numpy for docstrings
  • run tests with pytest

Questions:

@jatkinson1000 jatkinson1000 requested a review from raehik February 20, 2023 11:48
@jatkinson1000 jatkinson1000 self-assigned this Feb 20, 2023
@jatkinson1000 jatkinson1000 linked an issue Feb 20, 2023 that may be closed by this pull request
Implement CI and coding standards #5
Closed
@jatkinson1000 jatkinson1000 changed the title Add CI yaml file. Add CI. Feb 20, 2023
@jatkinson1000 jatkinson1000 changed the title Add CI. Add CI Feb 20, 2023
@raehik raehik changed the base branch from main to main-new February 20, 2023 12:34
raehik
raehik suggested changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@raehik raehik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. There are some linting checks done in the cross-platform build job. Could we move them into a single Linux job?

We should remember to edit the manual dependencies step once we've added more compatible packaging. I could add an general "CI tracker" issue.

.github/workflows/CI.yaml Outdated Show resolved Hide resolved
.github/workflows/CI.yaml Outdated Show resolved Hide resolved
.github/workflows/CI.yaml Outdated Show resolved Hide resolved
.github/workflows/CI.yaml Outdated Show resolved Hide resolved
.github/workflows/CI.yaml Outdated Show resolved Hide resolved
@raehik
Copy link
Contributor

raehik commented Feb 20, 2023

I also changed the base/target branch from main to main-new (via the Edit button on the right of the title).

@raehik raehik force-pushed the implement_CI branch 3 times, most recently from d5b3807 to e1efeb2 Compare February 20, 2023 15:23
@raehik
Copy link
Contributor

raehik commented Feb 21, 2023

CI is all red -- but that's good, because it means it's running. I'll make a new issue for making CI go green, since that's reliant on other changes.

@raehik
Copy link
Contributor

raehik commented Feb 21, 2023 •
edited
Loading

Squashed a bit and merging (edit: via rebase)

@raehik raehik merged commit f1d0652 into main Feb 21, 2023
@jatkinson1000
Copy link
Member Author

All seems good, thanks.
Some of the work I've been doing in the documentation branch should help towards going green.

@raehik raehik mentioned this pull request Mar 1, 2023
Closed
@raehik raehik deleted the implement_CI branch July 27, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raehik raehik raehik requested changes

Assignees

@jatkinson1000 jatkinson1000

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement CI and coding standards
2 participants
@jatkinson1000 @raehik