Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code documentation #7

Closed
jatkinson1000 opened this issue Feb 16, 2023 · 6 comments
Closed

Add code documentation #7

jatkinson1000 opened this issue Feb 16, 2023 · 6 comments
Assignees
Labels
code review Resulting from Feb 2023 code review documentation Improvements or additions to documentation

Comments

@jatkinson1000
Copy link
Member

Add docstrings.
Lint with pylint and write according to pydocstyle with numpy convention.

Other documentation?

  • ReadMe
  • Sphinx?
@jatkinson1000 jatkinson1000 added the documentation Improvements or additions to documentation label Feb 16, 2023
@jatkinson1000
Copy link
Member Author

I have started adding docstrings as part of the linting and cleaning process.

Once in a sensible state I will open a PR and @arthurBarthe can fill in any scientific information or data that I can't get from reading code.

@jatkinson1000 jatkinson1000 linked a pull request Feb 27, 2023 that will close this issue
23 tasks
@jatkinson1000 jatkinson1000 removed a link to a pull request Feb 27, 2023
23 tasks
@jatkinson1000
Copy link
Member Author

PR #17 will Add towards this by adding docstrings, linting, and processing with black.

@jatkinson1000 jatkinson1000 changed the title Add documentation Add code documentation Feb 28, 2023
@jatkinson1000
Copy link
Member Author

Changed this to explicitly address code documentation.
#18 has been opened to deal with project documentation.

@jatkinson1000 jatkinson1000 added the code review Resulting from Feb 2023 code review label Mar 1, 2023
@raehik
Copy link
Contributor

raehik commented Mar 1, 2023

#15 added CI which runs pylint, black and pydocstyle. The CI is currently failing because we haven't run these and gone through the report. That can be tracked in #16 .

@arthurBarthe
Copy link
Collaborator

I've added most of the docstrings requested. There are conflicts before I can merge with documentation though, and there are a few things I might want to discuss for the remaining docstrings.

@raehik
Copy link
Contributor

raehik commented Jul 5, 2023

@raehik raehik closed this as completed Jul 5, 2023
@raehik raehik closed this as not planned Won't fix, can't repro, duplicate, stale Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code review Resulting from Feb 2023 code review documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants