You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some of the pytorch in this repository is written in unconventional or inefficient ways that can make it hard to follow, or run at suboptimal levels of performance.
As part of the more detailed cleanup the working code needs looking at and refactoring.
This will involve branching off the documentation branch (to leverage the current docstring and linting improvements) and then merging back into main after #17 has closed #7 to try and minimise conflicts.
It should also not be merged back until #6 has been closed so that tests can be run to ensure behaviour is unchanged following refactoring.
The following approach is suggested:
create a new module FullyCNN.py or similar to house model, and perform updates in this.
Some of the pytorch in this repository is written in unconventional or inefficient ways that can make it hard to follow, or run at suboptimal levels of performance.
As part of the more detailed cleanup the working code needs looking at and refactoring.
This will involve branching off the
documentation
branch (to leverage the current docstring and linting improvements) and then merging back intomain
after #17 has closed #7 to try and minimise conflicts.It should also not be merged back until #6 has been closed so that tests can be run to ensure behaviour is unchanged following refactoring.
The following approach is suggested:
FullyCNN.py
or similar to house model, and perform updates in this.models1.py
(and associated code inmodels/*
) Replacemodels1
usage withfully_conv_net
#43The text was updated successfully, but these errors were encountered: