Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytorch refactor #19

Closed
jatkinson1000 opened this issue Feb 28, 2023 · 1 comment
Closed

Pytorch refactor #19

jatkinson1000 opened this issue Feb 28, 2023 · 1 comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@jatkinson1000
Copy link
Member

jatkinson1000 commented Feb 28, 2023

Some of the pytorch in this repository is written in unconventional or inefficient ways that can make it hard to follow, or run at suboptimal levels of performance.

As part of the more detailed cleanup the working code needs looking at and refactoring.

This will involve branching off the documentation branch (to leverage the current docstring and linting improvements) and then merging back into main after #17 has closed #7 to try and minimise conflicts.

It should also not be merged back until #6 has been closed so that tests can be run to ensure behaviour is unchanged following refactoring.

The following approach is suggested:

@jatkinson1000 jatkinson1000 linked a pull request Feb 28, 2023 that will close this issue
5 tasks
@jatkinson1000 jatkinson1000 added documentation Improvements or additions to documentation draft enhancement New feature or request labels Feb 28, 2023
@mondus mondus mentioned this issue Mar 1, 2023
5 tasks
@jatkinson1000 jatkinson1000 changed the title Inefficient and unconventional pytorch Pytorch refactor Mar 2, 2023
@mondus
Copy link
Contributor

mondus commented Jul 4, 2023

Cover in other issues #43 and #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants