Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in CI #129

Merged
merged 3 commits into from
May 6, 2024
Merged

Fix issues in CI #129

merged 3 commits into from
May 6, 2024

Conversation

EnricoTrizio
Copy link
Collaborator

@EnricoTrizio EnricoTrizio commented May 6, 2024

Description

Tests failing:

  • General, PyTorch dismissed the _accumulate function we were using in data/datamodule.py

I added the function explicitly in the datamodule file

  • On MacOS 14 because it doesn't support some device-related function anymore apparently

This closes #128

TODO

Check if tests succeed

Status

  • Ready to go

@EnricoTrizio EnricoTrizio changed the title Fix MPS on MacOS issue in CI Fix issues in CI May 6, 2024
@EnricoTrizio
Copy link
Collaborator Author

The problem should have been fixed in PyTorch from version 2.1 in pytorch/pytorch#111576
The test env installs PyTorch from conda-forge. Probably doing it from the PyTorch channel would give the latest pytorch where
the device issue has been solved

EDIT

I tried to use the latest version of PyTorch, as they apparently addressed the problem, but it didn't change much for us.
For now, I would test it on MacOS-13 and leave an open issue to remember to change it in the future when the 14 becomes stable again.

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 91.97%. Comparing base (8c2ede9) to head (703f7fa).

Additional details and impacted files

@EnricoTrizio EnricoTrizio requested a review from andrrizzi May 6, 2024 10:32
Copy link
Collaborator

@andrrizzi andrrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@EnricoTrizio EnricoTrizio marked this pull request as ready for review May 6, 2024 11:05
@EnricoTrizio EnricoTrizio merged commit 0d40dc1 into main May 6, 2024
12 checks passed
@EnricoTrizio EnricoTrizio deleted the fix_macOS_CI branch May 6, 2024 11:20
@svlandeg svlandeg mentioned this pull request Jun 3, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI are failing to due to out of memory issue
2 participants