Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The code is not compatible with torch 2.3, but is set to require the latest torch #143

Closed
Alexander-the-Evil opened this issue Jun 11, 2024 · 5 comments

Comments

@Alexander-the-Evil
Copy link

Pytorch v2.3.0 no longer defines function _accumulate in torch/_utils.py. The function is called from mlcolvar/data/datamodule.py.

Either the code needs to be changed to be executable with the new pytorch, or an older pytorch should be used in requirements.

@EnricoTrizio
Copy link
Collaborator

Ciao Alexander, thanks, we also noticed that, and it should have been fixed in #129.
The tests on the main branch are indeed running fine and they require torch 2.3.
To be sure, are you using an older version of the library with the new pytorch? For example, the PyPi version is bound to the latest stable release.

@luigibonati
Copy link
Owner

We should make a bugfix in the pypi version

This was referenced Jun 11, 2024
@luigibonati
Copy link
Owner

@Alexander-the-Evil I released a new version on PyPI which should fix the problem, you can try installing it again

https://pypi.org/project/mlcolvar/1.1.1/#description

@Alexander-the-Evil
Copy link
Author

Hi Enrico, hi Luigi,
thank you!
Yes, the issue was with the PyPi version. After that, I used locally installable version and it worked fine.
I also believe that this issue concerns tutorial colabs, now the only way to use them is to manually add lines to install pytorch 2.2.0.
But it is all solvable, just a small nuicance.
Thank you for the fix!
Alex

@EnricoTrizio
Copy link
Collaborator

Thank you Alexander for making us notice it!
Thanks also to @luigibonati for addressing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants