Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Menu #68

Merged
merged 23 commits into from
Nov 12, 2024
Merged

feat: Menu #68

merged 23 commits into from
Nov 12, 2024

Conversation

leoallvez
Copy link
Collaborator

Task

This pull request refers to tasks: LOR-340, LOR-342, LOR-344, LOR-346, LOR-348, LOR-350 and LOR-352

  • Does not apply to this pull request

Description

This pull request introduces the initial implementation of the menu. It now allows us to exit the app and access documentation, such as the terms of use and FAQ.

Please include a summary of the change and which issue is fixed.

  • Update LoryBook layout
  • Implement menu layout
  • Add navigation to Terms of Use (WebView)
  • Add navigation to FAQ (WebView)
  • Implement app exit functionality

Types of changes

  • New feature (non-breaking change which adds functionality).
  • Bug fix (non-breaking change which fixes an issue).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

What changed:

  • UI
  • Business rule
  • Documentation
  • Gradle or Build
  • Navigation
  • Tests
  • Resource files
  • Project architecture
  • Code style

Checklist

  • Have tested the changes.
  • Met all the acceptance requirements of this task.
  • Verified if branch is up-to-date with development (if not - rebase it or merge it).
  • Resolve git conflicts

If any of the acceptance criteria are not met, please explain why below

What is the criteria? Why it is different?

@leoallvez leoallvez requested a review from OdisBy October 29, 2024 14:24
@leoallvez leoallvez self-assigned this Oct 29, 2024
@leoallvez leoallvez requested a review from duhdoesk October 29, 2024 14:25
@leoallvez leoallvez changed the title feat:menu feat: menu Oct 29, 2024
@leoallvez leoallvez changed the title feat: menu feat: Menu Oct 29, 2024
Copy link
Member

@OdisBy OdisBy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boa!

@leoallvez leoallvez added this pull request to the merge queue Nov 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 11, 2024
@leoallvez leoallvez added this pull request to the merge queue Nov 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 11, 2024
@leoallvez leoallvez added this pull request to the merge queue Nov 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 11, 2024
@leoallvez leoallvez requested review from OdisBy and removed request for duhdoesk November 11, 2024 18:38
@leoallvez leoallvez added this pull request to the merge queue Nov 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 11, 2024
@leoallvez leoallvez removed the request for review from OdisBy November 11, 2024 18:39
@leoallvez leoallvez added this pull request to the merge queue Nov 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 11, 2024
@leoallvez leoallvez added this pull request to the merge queue Nov 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 11, 2024
@leoallvez leoallvez closed this Nov 11, 2024
@leoallvez leoallvez reopened this Nov 11, 2024
@OdisBy OdisBy added this pull request to the merge queue Nov 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 12, 2024
@OdisBy OdisBy merged commit 95c2315 into develop Nov 12, 2024
2 checks passed
@OdisBy OdisBy deleted the feat/menu branch November 12, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants