Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): Refactoring UserAuthentication class and uses #67

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

OdisBy
Copy link
Member

@OdisBy OdisBy commented Oct 26, 2024

Task

This pull request refers to task LOR-XX

  • Does not apply to this pull request

Description

  • Centralizing login to UserAuthentication.kt
  • Moving when to save user data and save token to UserAuthentication
  • Creating a helper class to EncryptedSharedPreferences
  • Fixing bug that when user save credentials, uninstall the app, install it again the app crashes

Types of changes

  • New feature (non-breaking change which adds functionality).
  • Bug fix (non-breaking change which fixes an issue).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

What changed:

  • UI
  • Business rule
  • Documentation
  • Gradle or Build
  • Navigation
  • Tests
  • Resource files
  • Project architecture
  • Code style

Checklist

  • Have tested the changes.
  • Met all the acceptance requirements of this task.
  • Verified if branch is up-to-date with development (if not - rebase it or merge it).
  • Resolve git conflicts

If any of the acceptance criteria are not met, please explain why below

What is the criteria? Why it is different?

@OdisBy OdisBy requested review from leoallvez and duhdoesk October 26, 2024 21:45
# Conflicts:
#	feature/auth/login/src/main/java/com/loryblu/feature/auth/login/LoginViewModel.kt
@OdisBy OdisBy linked an issue Nov 12, 2024 that may be closed by this pull request
2 tasks
@OdisBy OdisBy self-assigned this Nov 12, 2024
Copy link
Collaborator

@leoallvez leoallvez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

@OdisBy OdisBy added this pull request to the merge queue Nov 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 12, 2024
@OdisBy OdisBy merged commit 6f8dc6f into develop Nov 12, 2024
1 check passed
@OdisBy OdisBy deleted the feat/more-auth-refactor branch November 12, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sistema de salvar credenciais de login
2 participants