fix(logbook): Tasks not showing #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoallvez
approved these changes
Aug 9, 2024
| @@ -28,7 +28,7 @@ fun LogbookTaskRemote.toLogbookTask(): List<LogbookTask> { | |||
| val idToCard = TaskItem.getAllTaskItems().associateBy { it.taskId } | |||
| val logbookItems = mutableListOf<LogbookTask>() | |||
|
|
|||
| this.data.routine.map { remote -> | |||
| this.data.routine?.map { remote -> | |||
| logbookItems.add( | |||
| LogbookTask( | |||
| itemOfCategory = idToCard[remote.categoryId]!!, | |||
There was a problem hiding this comment.
O ideal é evitar forçar o uso de um valor nulo. Em vez disso, é melhor implementar uma verificação antes de utilizar o valor.
|
Muito bom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(logbook): Tasks not showing when has tasks of just one type "routine" or "study"
Task
This pull request refers to task LOR-XX
Description
Quando tinha tasks adicionadas de apenas um tipo, por exemplo todas as tasks da minha conta eram do LoryEstudioso eles não estavam sendo exibidas.
Types of changes
What changed:
Checklist
development(if not - rebase it or merge it).If any of the acceptance criteria are not met, please explain why below
What is the criteria? Why it is different?