Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(task): delete task #56

Merged
merged 8 commits into from
Aug 14, 2024
Merged

feat(task): delete task #56

merged 8 commits into from
Aug 14, 2024

Conversation

duhdoesk
Copy link
Collaborator

Task

This pull request refers to task LOR-XX

  • Does not apply to this pull request

Description

Please include a summary of the change and which issue is fixed.

Types of changes

  • New feature (non-breaking change which adds functionality).
  • Bug fix (non-breaking change which fixes an issue).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

What changed:

  • UI
  • Business rule
  • Documentation
  • Gradle or Build
  • Navigation
  • Tests
  • Resource files
  • Project architecture
  • Code style

Checklist

  • Have tested the changes.
  • Met all the acceptance requirements of this task.
  • Verified if branch is up-to-date with development (if not - rebase it or merge it).
  • Resolve git conflicts

If any of the acceptance criteria are not met, please explain why below

What is the criteria? Why it is different?

@OdisBy OdisBy changed the title ✨ feat: delete task. feat(task): delete task. Jun 25, 2024
@OdisBy OdisBy changed the title feat(task): delete task. feat(task): delete task Jun 25, 2024
@OdisBy OdisBy self-requested a review June 25, 2024 12:37
Copy link
Member

@OdisBy OdisBy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@OdisBy OdisBy self-requested a review July 1, 2024 13:03
Copy link
Member

@OdisBy OdisBy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dá uma olhada nesse pontos

.DS_Store Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acho q esse arquivo nn deveria ter subido

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acabei de ver aqui, é um arquivo do Mac OS, adicione no gitignore pfv e remova ele do pr

@OdisBy OdisBy self-requested a review August 11, 2024 10:22
Copy link
Member

@OdisBy OdisBy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boa!

@OdisBy
Copy link
Member

OdisBy commented Aug 12, 2024

@duhdoesk podemos fazer o merge?

@leoallvez leoallvez added this pull request to the merge queue Aug 14, 2024
Merged via the queue into develop with commit 5933aae Aug 14, 2024
1 check passed
@leoallvez leoallvez deleted the feat/delete_task branch August 14, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants