svelte: Update usageMatchRegex #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
though i didn't check other frameworks if they have this issue maybe we need a test for each framework's regexs? to check if they support linebreaks |
|
@terales Hi! It's been a while. Could you please take a look at this one? |
terales
approved these changes
Aug 27, 2023
huacnlee
pushed a commit
to huacnlee/i18n-ally
that referenced
this pull request
Aug 28, 2023
* fix: issue lokalise#132 for svelte * add `get()` support * replace .* with {key} * add support for spaces & line breaks in get() * Empty commit to trigger CI --------- Co-authored-by: Alex Terehov <[email protected]>
This was referenced Sep 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
formatnext to_andtas it's for example exported in the most popular at the moment i18n library for svelte$, but usinggetfunction fromsvelte).get(_)use case may appear when you are trying to get translation outside of svelte component where you can't automatically subscribe with$UPD: initial proposed regex was invalid. see #1001 and #1013