fix: Svelte regex wrong first capturing group (#1003) #1013
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1003
According to https://github.com/lokalise/i18n-ally/wiki/Custom-Framework
({key})
in regex should be first capturing group. I did not know about this when proposed #826, #1001I guess it would be really nice to have tests for regular expressions as it's in the core of i18n-ally.
Maybe at least we can add this info in the comment above this one?
Knowing that you must capture
({key})
as the first group is much more useful than knowing how to visualize regex. If you don't mind, I would like to open another PR which will add comments about this in every framework file, because the only place where I found this is wiki/Custom-Framework