Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a couple more item sources #1518

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Conversation

midgleyc
Copy link
Member

Description

Add a couple more item sources I have available at the end of a run.

Autumn leaf also gives +combat but I had spares. Loathing Idol also gives init and +combat, but I had /lots/ of spares.

How Has This Been Tested?

Did a run.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have based my pull request against the main branch or have a good reason not to.

@Alium58
Copy link
Member

Alium58 commented Oct 24, 2024

Awesome, thanks for adding more. Idol mic buff makes sense. I'm slightly concerned about crunchy leaves since +combat isn't always desirable. Need to ponder more, like would it better to only use the leaf if doEverything is true? Need to look where item provider is called again

@midgleyc
Copy link
Member Author

With a very shiny account, there is more than enough -combat to override one more +combat source.

Areas we don't want +combat but do want +item:

  • The Laugh Floor (but provideItem says "do everything" anyway)
  • The Hidden Park
  • Inside the Palindome
  • The Penultimate Fantasy Airship
  • The Castle in the Clouds in the Sky (Basement)
  • The Castle in the Clouds in the Sky (Ground Floor) (though not as much, only for the boning knife)
  • Twin Peak
  • The Extreme Slope (assuming +nc actually helps get the snowboarding adventures, not sure)
  • Friars locations if you're in low key summer and doing pirates

Seems reasonable to split it out. What should the priority be?

@Malibu-Stacey Malibu-Stacey merged commit b6c42c2 into loathers:main Oct 25, 2024
1 check passed
@midgleyc midgleyc deleted the more-item branch October 25, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants