Use return of exceptions, instead of implicitly throwing it (throw will be explicit) #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue #72 by modifying the exception handling in the C++ codebase. The current implementation throws exceptions implicitly within the functions, which is not the desired behavior. The requested change is to return the exceptions from these functions and explicitly throw them where these functions are called.
Summary of Changes
cpp/Platform.Exceptions/ThrowExtensions.h
file to replace thethrow
keyword with thereturn
keyword in the function definitions forNotSupportedException
andNotImplementedException
.Please review and merge these changes. Thank you!
Fixes #72.
🎉 Latest improvements to Sweep:
💡 To get Sweep to edit this pull request, you can: