Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use return of exceptions, instead of implicitly throwing it (throw will be explicit) #74

Closed
wants to merge 1 commit into from

Conversation

linksplatform-sweepai[bot]
Copy link

Description

This PR addresses the issue #72 by modifying the exception handling in the C++ codebase. The current implementation throws exceptions implicitly within the functions, which is not the desired behavior. The requested change is to return the exceptions from these functions and explicitly throw them where these functions are called.

Summary of Changes

  • Modified the cpp/Platform.Exceptions/ThrowExtensions.h file to replace the throw keyword with the return keyword in the function definitions for NotSupportedException and NotImplementedException.
  • The modified functions now return the exceptions instead of throwing them.

Please review and merge these changes. Thank you!

Fixes #72.


🎉 Latest improvements to Sweep:


💡 To get Sweep to edit this pull request, you can:

  • Leave a comment below to get Sweep to edit the entire PR
  • Leave a comment in the code will only modify the file
  • Edit the original issue to get Sweep to recreate the PR from scratch

@FreePhoenix888
Copy link
Member

Sweep: retry

@linksplatform-sweepai
Copy link
Author

linksplatform-sweepai bot commented Sep 24, 2023

❌ Could not find files to change

Please join our Discord to report this issue.

@linksplatform-sweepai linksplatform-sweepai bot deleted the sweep/use-return-of-exceptions_2 branch September 24, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use return of exceptions, instead of implicitly throwing it (throw will be explicit)
1 participant