-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use return of exceptions, instead of implicitly throwing it (throw will be explicit) #72
Comments
Sweep: do |
Actions (click)
❌ Unable to Complete PRI'm sorry, but it looks like an error has occurred. Try changing the issue description to re-trigger Sweep. If this error persists contact [email protected]. For bonus GPT-4 tickets, please report this bug on Discord. Please look at the generated plan. If something looks wrong, please add more details to your issue.
🎉 Latest improvements to Sweep:
💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. |
Sweep: in cpp/Platform.Exceptions/ThrowExtensions.h we have code like this: void NotSupportedException() { throw std::logic_error("Not supported exception."); }
auto NotSupportedExceptionAndReturn() { throw std::logic_error("Not supported exception."); } Replace |
Sweep: retry |
Sweep: retry |
Exceptions/cpp/Platform.Exceptions/ThrowExtensions.h
Lines 3 to 9 in 6549e77
replace with:
use:
Checklist
cpp/Platform.Exceptions/ThrowExtensions.h
❌ FailedThe text was updated successfully, but these errors were encountered: