Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config): migrate renovate config #653

Closed
wants to merge 2 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 20, 2025

The Renovate config in this repository needs migrating. Typically this is because one or more configuration options you are using have been renamed.

You don't need to merge this PR right away, because Renovate will continue to migrate these fields internally each time it runs. But later some of these fields may be fully deprecated and the migrations removed. So it's a good idea to merge this migration PR soon.

PLEASE NOTE: JSON5 config file migrated! All comments & trailing commas were removed.

🔕 Ignore: Close this PR and you won't be reminded about config migration again, but one day your current config may no longer be valid.

❓ Got questions? Does something look wrong to you? Please don't hesitate to request help here.


This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot mentioned this pull request Jan 20, 2025
3 tasks
@Yang-33 Yang-33 self-assigned this Jan 20, 2025
@Yang-33
Copy link
Contributor

Yang-33 commented Jan 20, 2025

Since the schedule and label aren't working as expected(#651), I'll investigate this in my forked repo before merging. Please wait a moment.

It seems that the label configuration is broken between these two PRs, but since the renovate.json5 files are exactly the same, it appears that the correct settings are not being provided to Renovate(though renovate read this config...). Fixing this should resolve everything.

@Yang-33 Yang-33 closed this in #654 Jan 21, 2025
Yang-33 added a commit that referenced this pull request Jan 21, 2025
Renovate recognizes packages in git submodule as `"packageName":
"https://github.com/line/line-openapi.git"`. however, this repository
specifies `"matchPackagePatterns": ["^line-openapi$"]`. This won't be
matched the submodule, and special config doesn't work. Thus
#651 was opened and merged
at noon, not at night.

This change fixes it.


Yang-33/line-bot-sdk-php-653-main-repository#2
checked this change works as expected. (this will be archived)

Close #653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant