Fix renovate config for gitsubmodule #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 20, 2025
|
renovate configs probably worked without this fix until around May 2024. This might be because the submodule's package name was recognized as the submodule's name (not the HTTP URL) at the time. As of August 2024, it seems to have changed to the HTTP URL (I guess renovate fixes this as bug, probably package name for git submodule was unintentional). 2024-05 (renovate config for line-openapi worked)
2024-08 (renovate config for line-openapi didn't worked, though configs were perfectly same)
|
mokuzon
approved these changes
Jan 21, 2025
Yang-33
added a commit
to line/line-bot-sdk-nodejs
that referenced
this pull request
Jan 21, 2025
Renovate recognizes packages in git submodule as `"packageName": "https://github.com/line/line-openapi.git"`. however, this repository specifies `"matchPackagePatterns": ["^line-openapi$"]`. This won't be matched the submodule, and special config doesn't work. This change fixes it. (same as line/line-bot-sdk-php#654)
Yang-33
added a commit
to line/line-bot-sdk-python
that referenced
this pull request
Jan 21, 2025
Renovate recognizes packages in git submodule as `"packageName": "https://github.com/line/line-openapi.git"`. however, this repository specifies `"matchPackagePatterns": ["^line-openapi$"]`. This won't be matched the submodule, and special config doesn't work. This change fixes it. Yang-33/line-bot-sdk-php-653-main-repository#2 checked this change works as expected. (this will be archived) (same as line/line-bot-sdk-php#654)
Yang-33
added a commit
to line/line-bot-sdk-java
that referenced
this pull request
Jan 21, 2025
Renovate recognizes packages in git submodule as `"packageName": "https://github.com/line/line-openapi.git"`. however, this repository specifies `"matchPackagePatterns": ["^line-openapi$"]`. This won't be matched the submodule, and special config doesn't work. This change fixes it. Yang-33/line-bot-sdk-php-653-main-repository#2 checked this change works as expected. (this will be archived) (same as line/line-bot-sdk-php#654)
Yang-33
added a commit
to line/line-bot-sdk-go
that referenced
this pull request
Jan 21, 2025
Renovate recognizes packages in git submodule as `"packageName": "https://github.com/line/line-openapi.git"`. however, this repository specifies `"matchPackagePatterns": ["^line-openapi$"]`. This won't be matched the submodule, and special config doesn't work. This change fixes it. Yang-33/line-bot-sdk-php-653-main-repository#2 checked this change works as expected. (this will be archived) (same as line/line-bot-sdk-php#654)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renovate recognizes packages in git submodule as
"packageName": "https://github.com/line/line-openapi.git". however, this repository specifies"matchPackagePatterns": ["^line-openapi$"]. This won't be matched the submodule, and special config doesn't work. Thus #651 was opened and merged at noon, not at night.This change fixes it.
Yang-33/line-bot-sdk-php-653-main-repository#2 checked this change works as expected. (this will be archived)
Close #653