-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude protobuf 4.x from armeria-grpc
module
#5992
Conversation
grpc
modulearmeria-grpc
module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, @jrhee17!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the check. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@chokoswitch said protobuf-jackson would support protobuf 3 for a while: curioswitch/protobuf-jackson#34 (comment) |
…le/scripts subrepo: subdir: "gradle/scripts" merged: "597bb9e29" upstream: origin: "https://github.com/line/gradle-scripts" branch: "main" commit: "597bb9e29" git-subrepo: version: "0.4.6" origin: "https://github.com/ingydotnet/git-subrepo" commit: "110b9eb"
Motivation:
With the recent release of 1.31.0, we received a report that protobuf 4 has been included as an api dependency.
This is probably a mistake since 1) the community isn't ready for protobuf 4 2) it's usually safer to follow the protobuf version used by
grpc-java
.The
api
configuration is a consumable configuration, which means it is difficult to detect these kind of issues directly.However, by checking the runtime dependencies for tests we can infer whether a version is inadvertently bumped.
In order to detect such mishaps, I also propose that a
failOnVersionConflict
variant is added.Because naively introducing
failOnVersionConflict
introduces many conflicts, I've added a variant which checks for specified dependencies only. (inspired by gradle/gradle#8813)One limitation is that the
dependencies
task is not available when afailOnVersionConflict
occurs. For this reason, once a failure due to a conflict occurs, it is encouraged to use the-PdebugDeps
flag with thedependencies
task.e.g.
Modifications:
protobuf-java
dependency fromprotobuf-jackson
failOnVersionConflict
method which checks version conflicts for specific dependencies onlyResult: