Introduce failOnVersionConflict per project/dep
#186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me go ahead and merge this PR since the armeria-side PR has already been approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Recently, a new armeria artifact was published with an unintended dependency bump up exposed in the resulting pom. (line/armeria#5992)
To avoid this, I propose that
failOnVersionConflictutility is used to detect if the resolved dependency.Because introducing
failOnVersionConflictfor all projects and dependencies makes adoption difficult due to the many conflicts, this variant can narrow the scope on detecting version conflicts. Additionally, if there is a dependency conflict but the finally resolved version is the intended version an exception isn't raised.Modification
failOnVersionConflictwhich detects version conflicts per dependency.