Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TW-1923: Improve search screen #1961

Merged
merged 9 commits into from
Dec 13, 2024
Merged

TW-1923: Improve search screen #1961

merged 9 commits into from
Dec 13, 2024

Conversation

hieutbui
Copy link
Member

@hieutbui hieutbui commented Jul 22, 2024

Ticket

Root cause

  • Currently, when search message is empty, search controller doesn't check for keyword is Matrix ID

Solution

  • When search message is empty, check if keyword is Matrix ID then hide empty widget.

Test recommendations

  • Search keywords that is a valid Matrix ID
  • Search keywords that is a valid Matrix ID but not complete (Ex: @test:domain.co)
  • Send message with a Matrix ID inside a room then search for this Matrix ID

Resolved

  • Web:
1923.web.mp4
  • Android:
  • IOS:

Copy link

This PR has been deployed to https://linagora.github.io/twake-on-matrix/1961

@hieutbui hieutbui force-pushed the TW-1923-Improve-search-screen branch from e12cfd6 to 7b370f6 Compare July 23, 2024 03:12
@hieutbui hieutbui changed the title [WIP] TW-1923: Improve search screen TW-1923: Improve search screen Jul 23, 2024
@hieutbui hieutbui force-pushed the TW-1923-Improve-search-screen branch from 98c94cb to db457c5 Compare July 23, 2024 06:30
@sherlockvn
Copy link
Contributor

not in the DOD, but i think this case, we should remove the Messages section too
image

@KhaledNjim
Copy link
Contributor

not in the DOD, but i think this case, we should remove the Messages section too image

Updated

image

@nqhhdev nqhhdev force-pushed the TW-1923-Improve-search-screen branch from b50199d to 0479eda Compare November 25, 2024 03:23
@nqhhdev
Copy link
Member

nqhhdev commented Nov 25, 2024

I rebased and tested it on mobile, web works well

@nqhhdev
Copy link
Member

nqhhdev commented Nov 25, 2024

I have one concern about padding in chat search on web. WDYT @hoangdat @KhaledNjim

  • Currently
Screenshot 2024-11-25 at 10 23 57
  • After updated
Screenshot 2024-11-25 at 10 22 32

@hoangdat
Copy link
Member

hoangdat commented Dec 4, 2024

I have one concern about padding in chat search on web. WDYT @hoangdat @KhaledNjim

please base on the new style for this.

@nqhhdev
Copy link
Member

nqhhdev commented Dec 5, 2024

Reverted style
Screenshot 2024-12-04 at 23 48 15

@KhaledNjim
Copy link
Contributor

According to the notion page, the explanation text when no results are found should be removed, its still present in some screens

  • When searching for a contact while creating a new chat
improve_search.mp4
  • When searching in contacts screen

image

@nqhhdev
Copy link
Member

nqhhdev commented Dec 10, 2024

Hi @hoangdat @KhaledNjim, I updated the search result in contact screen, add members into group and create a new chat.
Pls help me review and test it again. Thanks all

Screen.Recording.2024-12-10.at.15.07.55.mov

@hoangdat hoangdat merged commit 4dd46da into main Dec 13, 2024
7 checks passed
@hoangdat hoangdat deleted the TW-1923-Improve-search-screen branch December 13, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants