Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TW-1827: online status is not updated correctly #1879

Merged
merged 4 commits into from
Jun 25, 2024
Merged

TW-1827: online status is not updated correctly #1879

merged 4 commits into from
Jun 25, 2024

Conversation

sherlockvn
Copy link
Collaborator

@sherlockvn sherlockvn commented Jun 18, 2024 •
edited
Loading

Updated:

  • for chat we don't have lastActiveTimestamp, keep offine status (in this case, it means user never online before or in the case of can't get presence of user)
  • for people that offline longer than 10 hours, we display aWhile ago instead of offline

android:

Screen.Recording.2024-06-20.at.15.01.18.mov

ios:

RPReplay_Final1718874480.MP4

@github-actions GitHub Actions
Copy link

This PR has been deployed to https://linagora.github.io/twake-on-matrix/1879

@Te-Z
Copy link
Contributor

Te-Z commented Jun 18, 2024

@tprudentova is this solution ok for you ?

Updated:

  • for chat we don't have lastActiveTimestamp, keep offine status (in this case, it means user never online before or in the case of can't get presence of user)
  • for people that offline longer than 10 hours, we display aWhile ago instead of offline

@tprudentova
Copy link
Collaborator

@Te-Z if the user was online >10 hours ago, but we can get information about the time when that person was online, please display exact time (like "online 3 days ago")
"Offline" and "online a while ago" only for the users for which we don't have any information

@sherlockvn
Copy link
Collaborator Author

@Te-Z if the user was online >10 hours ago, but we can get information about the time when that person was online, please display exact time (like "online 3 days ago") "Offline" and "online a while ago" only for the users for which we don't have any information

After how many days offline should the status change to "online a while ago"?. For users we don't have information, we display "offline"

@Te-Z
Copy link
Contributor

Te-Z commented Jun 18, 2024

@Te-Z if the user was online >10 hours ago, but we can get information about the time when that person was online, please display exact time (like "online 3 days ago") "Offline" and "online a while ago" only for the users for which we don't have any information

After how many days offline should the status change to "online a while ago"?. For users we don't have information, we display "offline"

@sherlockvn please tag @tprudentova if you need to ask her or send her a message via chat for more efficiency

@sherlockvn
Copy link
Collaborator Author

@tprudentova

@tprudentova
Copy link
Collaborator

@sherlockvn @Te-Z I think we can display "online a while ago" after 30 days of absence, similar to telegram

@sherlockvn
Copy link
Collaborator Author

okay np

@sherlockvn sherlockvn force-pushed the TW-1827/online-status-isnot-updated-correctly branch from 34d08d6 to 6e7f9d7 Compare June 21, 2024 09:23
@sherlockvn sherlockvn changed the title TW-1827: online status isnot updated correctly TW-1827: online status is not updated correctly Jun 21, 2024
@sherlockvn sherlockvn force-pushed the TW-1827/online-status-isnot-updated-correctly branch from 6e7f9d7 to a685378 Compare June 24, 2024 03:31
@sherlockvn sherlockvn force-pushed the TW-1827/online-status-isnot-updated-correctly branch from a685378 to c75e804 Compare June 24, 2024 03:36
Te-Z
Te-Z reviewed Jun 24, 2024
View reviewed changes
lib/pages/chat/chat.dart Outdated Show resolved Hide resolved
@sherlockvn sherlockvn force-pushed the TW-1827/online-status-isnot-updated-correctly branch from c75e804 to dcd5ea6 Compare June 25, 2024 03:06
@sherlockvn sherlockvn force-pushed the TW-1827/online-status-isnot-updated-correctly branch from dcd5ea6 to a46c068 Compare June 25, 2024 03:08
@Te-Z Te-Z merged commit b63fcbe into main Jun 25, 2024
7 checks passed
@Te-Z Te-Z deleted the TW-1827/online-status-isnot-updated-correctly branch June 25, 2024 13:06
@nqhhdev nqhhdev mentioned this pull request Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nqhhdev nqhhdev nqhhdev approved these changes

@hieutbui hieutbui hieutbui approved these changes

@Te-Z Te-Z Te-Z approved these changes

@hoangdat hoangdat Awaiting requested review from hoangdat hoangdat is a code owner

@dab246 dab246 Awaiting requested review from dab246 dab246 is a code owner

@tddang-linagora tddang-linagora Awaiting requested review from tddang-linagora tddang-linagora is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sherlockvn @Te-Z @tprudentova @hieutbui @nqhhdev