TW-1827: write widget test for chat_app_bar_title

linagora · Jun 25, 2024 · a46c068 · a46c068
1 parent 8b4d523
commit a46c068
Show file tree

Hide file tree

Showing 5 changed files with 364 additions and 14 deletions.
diff --git a/assets/l10n/intl_en.arb b/assets/l10n/intl_en.arb
@@ -2572,7 +2572,7 @@
       "hour": {}
     }
   },
-  "onlineDayAgo": "online {day} day ago",
+  "onlineDayAgo": "online {day}d ago",
   "@onlineDayAgo": {
     "placeholders": {
       "day": {}

diff --git a/lib/pages/chat/chat.dart b/lib/pages/chat/chat.dart
@@ -1,6 +1,5 @@
 import 'dart:async';
 import 'dart:io';
-import 'package:connectivity_plus/connectivity_plus.dart';
 import 'package:fluffychat/pages/chat/chat_actions.dart';
 import 'package:fluffychat/pages/chat/events/message_content_mixin.dart';
 import 'package:fluffychat/presentation/extensions/event_update_extension.dart';
@@ -262,9 +261,6 @@ class ChatController extends State<Chat>
 
   ValueNotifier<CachedPresence?> cachedPresenceNotifier = ValueNotifier(null);
 
-  final StreamController<ConnectivityResult>
-      connectivityResultStreamController = StreamController.broadcast();
-
   StreamController<CachedPresence> cachedPresenceStreamController =
       StreamController.broadcast();
 
@@ -2008,6 +2004,7 @@ class ChatController extends State<Chat>
     InViewNotifierListCustom.of(context)?.dispose();
     replyEventNotifier.dispose();
     cachedPresenceStreamController.close();
+    cachedPresenceNotifier.dispose();
     super.dispose();
   }
 

diff --git a/lib/pages/chat/chat_app_bar_title.dart b/lib/pages/chat/chat_app_bar_title.dart
@@ -190,18 +190,18 @@ class _DirectChatAppBarStatusContent extends StatelessWidget {
                 );
                 if (connectivitySnapshot.hasData &&
                     connectivityResult == ConnectivityResult.none) {
-                  return _ChatAppBarTitleText(
+                  return ChatAppBarTitleText(
                     text: L10n.of(context)!.noConnection,
                   );
                 }
                 if (directChatPresence == null) {
-                  return _ChatAppBarTitleText(
+                  return ChatAppBarTitleText(
                     text: L10n.of(context)!.loading,
                   );
                 }
                 final typingText = room.getLocalizedTypingText(context);
                 if (typingText.isEmpty) {
-                  return _ChatAppBarTitleText(
+                  return ChatAppBarTitleText(
                     text: room
                         .getLocalizedStatus(
                           context,
@@ -241,11 +241,11 @@ class _GroupChatAppBarStatusContent extends StatelessWidget {
         );
 
         if (snapshot.hasData && connectivityResult == ConnectivityResult.none) {
-          return _ChatAppBarTitleText(text: L10n.of(context)!.noConnection);
+          return ChatAppBarTitleText(text: L10n.of(context)!.noConnection);
         }
         final typingText = room.getLocalizedTypingText(context);
         if (typingText.isEmpty) {
-          return _ChatAppBarTitleText(
+          return ChatAppBarTitleText(
             text: room.getLocalizedStatus(context).capitalize(context),
           );
         } else {
@@ -256,8 +256,9 @@ class _GroupChatAppBarStatusContent extends StatelessWidget {
   }
 }
 
-class _ChatAppBarTitleText extends StatelessWidget {
-  const _ChatAppBarTitleText({
+class ChatAppBarTitleText extends StatelessWidget {
+  const ChatAppBarTitleText({
+    super.key,
     required this.text,
   });
 

diff --git a/lib/utils/room_status_extension.dart b/lib/utils/room_status_extension.dart
@@ -16,7 +16,7 @@ extension RoomStatusExtension on Room {
 
   String getLocalizedStatus(BuildContext context, {CachedPresence? presence}) {
     if (isDirectChat) {
-      return _getLocalizedStatusDirectChat(presence, context);
+      return getLocalizedStatusDirectChat(presence, context);
     }
 
     return _getLocalizedStatusGroupChat(context);
@@ -98,7 +98,7 @@ extension RoomStatusExtension on Room {
     return L10n.of(context)!.countMembers(totalMembers);
   }
 
-  String _getLocalizedStatusDirectChat(
+  String getLocalizedStatusDirectChat(
     CachedPresence? directChatPresence,
     BuildContext context,
   ) {