-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TAS-2514] 💄Listing page header UI revamp #1966
Merged
williamchong
merged 20 commits into
likecoin:develop
from
AuroraHuang22:feature/listing-header
Dec 11, 2024
Merged
Changes from 6 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
2fe8a57
🔥 Remove breadcrumb
AuroraHuang22 8a02cae
✨Add arrows for tags navigation
AuroraHuang22 129c493
✨ Add random search placeholder
AuroraHuang22 9f50f42
🎨Add click filter handling for desktop version
AuroraHuang22 23ac5df
📱 Handle tags scroll bar for phone version
AuroraHuang22 8171451
🎨 Add tags to modify sorting display
AuroraHuang22 6820f5e
🎨 Add en search placeholder
AuroraHuang22 e27b1b5
🎨 Update search suggestions
AuroraHuang22 1a35067
💄 Fix filter dialog position for desktop
nwingt e67a642
🍱 Fix arrow right icon style
nwingt f356177
🎨 Clean up tags container code
nwingt 7897e27
🐛 Fix undefined OG title
nwingt 9feb248
🐛 Fix latest book sorting
nwingt e005d95
💄 Add active tag title in header
nwingt b5d6825
🐛 Fix gradient not displaying on mobile version
AuroraHuang22 14ed980
💄 Adjust search border radius
AuroraHuang22 3ccdb97
🚸 Enable drag-to-scroll for tags list
AuroraHuang22 1874fda
🚸 Auto-apply first random keyword on empty search
AuroraHuang22 257274c
🚸 Improve scrolling behavior
AuroraHuang22 a9cc968
🚸 Auto-scroll to active tag
AuroraHuang22 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -470,6 +470,7 @@ | |||||||
"listing_page_header_homePage": "Home", | ||||||||
"listing_page_header_listingPage": "Bookstore", | ||||||||
"listing_page_header_sort": "Sort: {sort}", | ||||||||
"listing_page_header_sort_default": "Default", | ||||||||
"listing_page_header_sort_higher_price": "Price: High to Low", | ||||||||
"listing_page_header_sort_latest": "Latest", | ||||||||
"listing_page_header_sort_lower_price": "Price: Low to High", | ||||||||
|
@@ -480,6 +481,7 @@ | |||||||
"listing_page_QA_label": "What is the difference between ebooks and paperbacks?", | ||||||||
"listing_page_QA_title": "FAQ", | ||||||||
"listing_page_search": "Search", | ||||||||
"listing_page_search_label": "book title or author", | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
"listing_page_search_not_found": "Please try different keywords.", | ||||||||
"listing_page_search_recommend": "Or explore our recommended books:", | ||||||||
"listing_page_search_result": "The search results for '{query}':", | ||||||||
|
@@ -1029,6 +1031,8 @@ | |||||||
"Stake your LikeCoin to gain extra reward, and participate in community governance." | ||||||||
], | ||||||||
"tag_all_title": "All", | ||||||||
"tag_all_featured": "Featured", | ||||||||
"tag_all_latest": "Latest Arrivals", | ||||||||
"tooltip_coming_soon": "Coming Soon", | ||||||||
"tooltip_no_nft": "No owned NFTs to transfer", | ||||||||
"tooltip_share": "Copy URL", | ||||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe should check locale is chinese first, or we need to have a set of suggestion for english/fallback