[TAS-2514] 💄Listing page header UI revamp #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AuroraHuang22
added a commit
that referenced
this pull request
Nov 24, 2024
williamchong
requested changes
Nov 26, 2024
Comment on lines
+100
to
+103
| this.placeholderText = this.getRandomPlaceholder(); | ||
| this.$nextTick(() => { | ||
| this.$refs.searchInput?.focus(); | ||
| }); |
There was a problem hiding this comment.
Maybe should check locale is chinese first, or we need to have a set of suggestion for english/fallback
src/locales/en.json
Outdated
| @@ -480,6 +481,7 @@ | |||
| "listing_page_QA_label": "What is the difference between ebooks and paperbacks?", | |||
| "listing_page_QA_title": "FAQ", | |||
| "listing_page_search": "Search", | |||
| "listing_page_search_label": "book title or author", | |||
There was a problem hiding this comment.
Suggested change
| "listing_page_search_label": "book title or author", | |
| "listing_page_search_label": "Book title or Author", | |
williamchong
approved these changes
Nov 28, 2024
AuroraHuang22
added a commit
that referenced
this pull request
Nov 29, 2024
nwingt
added a commit
that referenced
this pull request
Dec 6, 2024
nwingt
added a commit
that referenced
this pull request
Dec 6, 2024
nwingt
added a commit
that referenced
this pull request
Dec 6, 2024
AuroraHuang22
added a commit
that referenced
this pull request
Dec 9, 2024
AuroraHuang22
force-pushed
the
feature/listing-header
branch
from
45613f9 to
3ccdb97
Compare
AuroraHuang22
added a commit
that referenced
this pull request
Dec 10, 2024
williamchong
requested changes
Dec 10, 2024
AuroraHuang22
added a commit
that referenced
this pull request
Dec 10, 2024
AuroraHuang22
added a commit
that referenced
this pull request
Dec 10, 2024
AuroraHuang22
added a commit
that referenced
this pull request
Dec 11, 2024
AuroraHuang22
added a commit
that referenced
this pull request
Dec 11, 2024
nwingt
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default.mp4
RPReplay_Final1732622533.MP4