-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi: bump lnd to v0.17.0-beta #645
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b3c0d0e
multi: bump lnd to v0.17.0-beta
guggero 322a961
multi: fix linter issues
guggero bbd4052
readme: add disable option for sub-servers
ViktorTigerstrom a4edf44
README: bump versions
guggero d924cea
version: bump to v0.11.0-alpha
guggero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: taproot assets included is at v0.2.4.0.XXX in the
go.mod
fileThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, Taproot Assets is a bit of an outlier here. Should've added that to the PR description: Since we're very close to releasing
v0.3
, we will be doing anotherlitd
release soon. But because a lot of things in themain
branch for thev0.3
release are breaking changes, we need to stay on av0.2.3
base for now. So I just pushed a branch with thelnd
update and didn't create a PR for it, as we couldn't merge it anywhere anyway. But as soon asv0.3
is out, everything will be smooth again.Oh and the
v0.2.4
is just a weird thing go modules does, when it uses a commit based pseudo version, it actually increases the patch version. The closest tag to the commit used is actuallyv0.2.3
, there is nov0.2.4
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, makes sense. Thanks for explaining!