multi: bump lnd to v0.17.0-beta #645
Conversation
guggero
force-pushed
the
lnd-17-update
branch
2 times, most recently
from
057728b to
8b7dcac
Compare
There was a problem hiding this comment.
LGTM pending LiT version bump and Readme update.
Think we should also include these readme updates here: #543
|
Updated the README and also added a version bump for |
There was a problem hiding this comment.
tACK LGTM!
Tested the sessions, loop & pool flow with the new changes, and those seems to be working as expected!
Very nitty: I think the last 2 commits can be squashed into 1, but definitely not a blocker :)!
Just wanted to sanity check, since the description of the PR doesn't mention that this is dependent on lightninglabs/taproot-assets#536, but depends on all other bumps, should that not be the case?
| @@ -146,6 +147,7 @@ The following table shows the supported combinations: | |||
|
|
|||
| | LiT | LND | Loop | Faraday | Pool | Taproot Assets | | |||
| |-------------------|--------------|--------------|---------------|--------------|----------------| | |||
| | **v0.11.0-alpha** | v0.17.0-beta | v0.26.3-beta | v0.2.11-alpha | v0.6.4-beta | v0.2.3-alpha | | |||
There was a problem hiding this comment.
nit: taproot assets included is at v0.2.4.0.XXX in the go.mod file
There was a problem hiding this comment.
You're right, Taproot Assets is a bit of an outlier here. Should've added that to the PR description: Since we're very close to releasing v0.3, we will be doing another litd release soon. But because a lot of things in the main branch for the v0.3 release are breaking changes, we need to stay on a v0.2.3 base for now. So I just pushed a branch with the lnd update and didn't create a PR for it, as we couldn't merge it anywhere anyway. But as soon as v0.3 is out, everything will be smooth again.
Oh and the v0.2.4 is just a weird thing go modules does, when it uses a commit based pseudo version, it actually increases the patch version. The closest tag to the commit used is actually v0.2.3, there is no v0.2.4.
There was a problem hiding this comment.
Ah ok, makes sense. Thanks for explaining!
guggero
changed the title
Replaces #633.
Depends on:
lnd v0.17.0-beta(and a bump inlndclient).