Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd+example: update with Status server access #81

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

ellemouton
Copy link
Member

No description provided.

@ViktorTigerstrom
Copy link
Contributor

Rebased the PR and removed the replacement of the LiT dependency as we've now updated the wasm-client to use the latest version of LiT which has support for the status cmd!

@ViktorTigerstrom ViktorTigerstrom marked this pull request as ready for review October 23, 2023 18:53
@ViktorTigerstrom
Copy link
Contributor

Pinging @ellemouton as I can't request a review from her, as she's the author of the PR :)! Would really appreciate if you'd be able to take a quick glance to see that the changes looks good!

@ViktorTigerstrom
Copy link
Contributor

Reworded the commit as it now only edits example/index.html.

Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK LGTM 🚀

I think we can merge this without @ellemouton's review since this is just the html changes.

Copy link

@itsrachelfish itsrachelfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, confirmed that the example subserver RPC is working 👍

image

@ViktorTigerstrom ViktorTigerstrom merged commit 9db0d53 into lightninglabs:master Oct 23, 2023
5 checks passed
@ellemouton ellemouton deleted the subservers branch October 24, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants