Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for litd subserver status RPC #19

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Conversation

itsrachelfish
Copy link
Contributor

This PR adds support for the new litd subserver status RPC

@itsrachelfish itsrachelfish force-pushed the lit-subserver-status branch 2 times, most recently from 2b336f9 to 8e41f95 Compare June 20, 2023 21:24
@itsrachelfish itsrachelfish force-pushed the lit-subserver-status branch 2 times, most recently from 5eb5809 to 2bddd96 Compare July 26, 2023 10:34
@jamaljsr
Copy link
Member

What branches do I need to be on for litd and LNC in order to run this locally? Can you provide steps to test this?

@jamaljsr
Copy link
Member

Adding this here for reference from https://gist.github.com/itsrachelfish/5921fc5b684352792d9e2209ef6ea769

Disabled subserver setup

lightning-terminal

lightning-node-connect

  • git checkout Elle's PR - cmd+example: update with Status server access lightning-node-connect#81
  • Add the following lines to the bottom of the lightning-node-connect/cmd/wasm-client/go.mod file
    replace github.com/lightninglabs/lightning-terminal => github.com/ellemouton/lightning-terminal 650cb0a32b99cfd05f4616c383d53a7ffe8e537f
    replace google.golang.org/protobuf => github.com/lightninglabs/protobuf-go-hex-display v1.30.0-hex-display
  • Run cd cmd/wasm-client
  • Run go mod tidy
  • Run cd ../..
  • Run make wasm

lnc-core

  • git checkout Rachel's PR - Add support for litd subserver status RPC #19
  • Copy all .proto files from lightning-terminal/proto folder into lnc-core/protos/lit/v0.10.1-alpha
  • Note: Once Elle's PR 541 is merged you will be able to run yarn update-protos instead of manually copying them
  • Run yarn generate
  • Run yarn build
  • Run yarn link

lnc-web

  • Run yarn link "@lightninglabs/lnc-core"
  • Edit DEFAULT_CONFIG in lib/lnc.ts to point to the new wasm file:
    const DEFAULT_CONFIG = {
        wasmClientCode: 'http://lnc.local/wasm-client-subserver.wasm',
        namespace: 'default',
        serverHost: 'localhost:11110'
    } as Required<LncConfig>;
  • Note: I run a webserver on my computer to serve the updated wasm file
  • Run yarn build
  • Run yarn link

dev-resources

  • Run regtest build
  • Run regtest start

terminal-web

@lightninglabs-deploy
Copy link

@jamaljsr: review reminder

Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK LGTM 👌

@jamaljsr jamaljsr merged commit bf6a037 into main Oct 19, 2023
@jamaljsr jamaljsr deleted the lit-subserver-status branch September 9, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants