Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap 5 #940

Open
Changaco opened this issue Jan 19, 2018 · 6 comments · May be fixed by #2328
Open

Bootstrap 5 #940

Changaco opened this issue Jan 19, 2018 · 6 comments · May be fixed by #2328
Labels
DevX making it easier to develop and maintain Liberapay visual issues about how Liberapay looks

Comments

@Changaco
Copy link
Member

Changaco commented Jan 19, 2018 •
edited
Loading

Bootstrap 4 has finally been released (official announcement)! Bootstrap 5 has been released: https://blog.getbootstrap.com/2021/05/05/bootstrap-5/! Anyone wants to try migrating Liberapay to the new version?
@elegaanz elegaanz assigned elegaanz and unassigned elegaanz Jan 19, 2018
@elegaanz
Copy link
Contributor

I tried to do it, but I don't know the code good enough to understand how to make it work correctly. I'll let someone else do it.

@Changaco Changaco self-assigned this Jan 21, 2018
@Changaco Changaco mentioned this issue Jan 22, 2018
Closed
@Changaco Changaco added the DevX making it easier to develop and maintain Liberapay label Jan 22, 2018
@Changaco Changaco removed their assignment Jan 22, 2018
@Changaco

This comment was marked as outdated.

Sign in to view
@Changaco

This comment was marked as outdated.

Sign in to view
@Changaco Changaco added the visual issues about how Liberapay looks label Sep 30, 2018
@Changaco Changaco mentioned this issue Oct 4, 2019
Open
@Changaco Changaco mentioned this issue Nov 27, 2019
Closed
@Changaco Changaco mentioned this issue May 20, 2020
Closed
@Changaco
Copy link
Member Author

Changaco commented May 7, 2021

Bootstrap 5 has been released: https://blog.getbootstrap.com/2021/05/05/bootstrap-5/

@Changaco Changaco changed the title Bootstrap 4 Bootstrap 5 Mar 20, 2024
@Changaco Changaco mentioned this issue Mar 22, 2024
Merged
@iacore
Copy link

iacore commented Mar 22, 2024 •
edited
Loading

I looked at # 944. I thought there wasa no breaking changes to v4.0.

Bootstrap 5 introduced a lot of breaking changes. Please take a look.

https://getbootstrap.com/docs/5.0/migration/

I don't know Liberapay or Bootstrap 5, and I wonder is there any benefit moving to v5.

@Changaco
Copy link
Member Author

Both Bootstrap v4 and v5 made breaking changes. If I remember correctly, Bootstrap 5 reversed some of the changes of Bootstrap 4, so jumping from v3 to v5 should actually require fewer changes than if we had done v3 to v4 and then v4 to v5.

Bootstrap v3 is obsolete and requires jQuery (#1940). The alternative to upgrading Bootstrap would be switching to another framework, but the benefits of doing so would have to outweigh the costs.

@iacore iacore linked a pull request Mar 23, 2024 that will close this issue
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DevX making it easier to develop and maintain Liberapay visual issues about how Liberapay looks
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Bootstrap to v5.3.3 iacore/liberapay.com
Bootstrap v4 liberapay/liberapay.com
3 participants
@Changaco @elegaanz @iacore