Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make blaze_sym::path member optional #293

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Make blaze_sym::path member optional #293

merged 2 commits into from
Aug 3, 2023

Commits on Aug 2, 2023

  1. Make blaze_sym::path member optional 

    We recently made the path attribute in the Rust symbolize::Sym type
optional. For the C API, we mapped a None to an empty string. That is
arguably not in line with how optionality is generally encoded in C.
Switch to using a NULL pointer instead.

Signed-off-by: Daniel Müller <[email protected]>
    @d-e-s-o
    d-e-s-o committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    f038e4c View commit details
    Browse the repository at this point in the history

  2. Add more tests for ELF and DWARF symbolization 

    This change extends our ELF and DWARF symbolization tests. ELF
symbolization was not actually exercised from Rust, while DWARF
symbolization was lacking in the C API tests. So fix that. Also extend
the tests to check for source directories, file names, and line numbers
(or lack thereof).

Signed-off-by: Daniel Müller <[email protected]>
    @d-e-s-o
    d-e-s-o committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    898dbe6 View commit details
    Browse the repository at this point in the history