Make blaze_sym::path member optional #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently made the path attribute in the Rust symbolize::Sym type optional. For the C API, we mapped a None to an empty string. That is arguably not in line with how optionality is generally encoded in C. Switch to using a NULL pointer instead. Signed-off-by: Daniel Müller <[email protected]>
This change extends our ELF and DWARF symbolization tests. ELF symbolization was not actually exercised from Rust, while DWARF symbolization was lacking in the C API tests. So fix that. Also extend the tests to check for source directories, file names, and line numbers (or lack thereof). Signed-off-by: Daniel Müller <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #293 +/- ##
=======================================
Coverage 89.27% 89.28%
=======================================
Files 37 37
Lines 4652 4656 +4
=======================================
+ Hits 4153 4157 +4
Misses 499 499
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently made the path attribute in the Rust symbolize::Sym type optional. For the C API, we mapped a None to an empty string. That is arguably not in line with how optionality is generally encoded in C. Switch to using a NULL pointer instead.