Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔨 Adjust biome rulelint/correctness/noNodejsModules setting #402

Merged
merged 1 commit into from
Dec 27, 2024
Merged

🔨 Adjust biome rulelint/correctness/noNodejsModules setting #402

merged 1 commit into from
Dec 27, 2024
+11 −15

Conversation

hoshinotsuyoshi
Copy link
Member

Summary

🔧 Adjust biome rulelint/correctness/noNodejsModules setting

Related Issue

closes #401

Changes

Testing

Other Information

@hoshinotsuyoshi hoshinotsuyoshi self-assigned this Dec 27, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 27, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: dd21de2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

hoshinotsuyoshi
hoshinotsuyoshi commented Dec 27, 2024
View reviewed changes
frontend/packages/db-structure/biome.jsonc
@@ -8,6 +8,7 @@
"linter": {
"rules": {
"correctness": {
"noNodejsModules": "error",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The frontend/packages/db-structure/src/schema/ directory (not the parser) likely still requires noNodejsModules, I suppose.

Base automatically changed from add-docs-robots-txt to main December 27, 2024 07:32
@hoshinotsuyoshi hoshinotsuyoshi force-pushed the adjust-no-nodejs-modules-rule branch from be1d12d to dd21de2 Compare December 27, 2024 08:31
@hoshinotsuyoshi hoshinotsuyoshi changed the title 🔧 Adjust biome rulelint/correctness/noNodejsModules setting 🔨 Adjust biome rulelint/correctness/noNodejsModules setting Dec 27, 2024
@hoshinotsuyoshi hoshinotsuyoshi marked this pull request as ready for review December 27, 2024 08:35
@hoshinotsuyoshi hoshinotsuyoshi requested a review from a team as a code owner December 27, 2024 08:35
@hoshinotsuyoshi hoshinotsuyoshi requested review from FunamaYukina, junkisai, MH4GF and sasamuku and removed request for a team December 27, 2024 08:35
FunamaYukina
FunamaYukina approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@FunamaYukina FunamaYukina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your quick response 🙏.
I understand that the noNodejsModules restriction applies in the following cases.

  • frontend/packages/db-structure(not the parser)
  • frontend/packages/erd-core

@hoshinotsuyoshi
Copy link
Member Author

hoshinotsuyoshi commented Dec 27, 2024 •
edited
Loading

Yes! And the parser directory in db-structure contains many ignore comments. This issue remains unresolved 😅.

@hoshinotsuyoshi hoshinotsuyoshi added this pull request to the merge queue Dec 27, 2024
Merged via the queue into main with commit 064997b Dec 27, 2024
13 checks passed
@hoshinotsuyoshi hoshinotsuyoshi deleted the adjust-no-nodejs-modules-rule branch December 27, 2024 09:22
@MH4GF
Copy link
Member

MH4GF commented Dec 27, 2024

Thanks!!
Maybe we could separate the parser into a separate package 💭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FunamaYukina FunamaYukina FunamaYukina approved these changes

@junkisai junkisai Awaiting requested review from junkisai junkisai is a code owner automatically assigned from liam-hq/liam-dev

@MH4GF MH4GF Awaiting requested review from MH4GF MH4GF is a code owner automatically assigned from liam-hq/liam-dev

@sasamuku sasamuku Awaiting requested review from sasamuku sasamuku is a code owner automatically assigned from liam-hq/liam-dev

Assignees

@hoshinotsuyoshi hoshinotsuyoshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust biome rulelint/correctness/noNodejsModules setting
3 participants
@hoshinotsuyoshi @MH4GF @FunamaYukina