🔧 Adjust biome rulelint/correctness/noNodejsModules setting

liam-hq · Dec 27, 2024 · be1d12d · be1d12d
1 parent 7e9b463
commit be1d12d
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 17 deletions.
diff --git a/frontend/apps/docs/app/docs/sitemap.ts b/frontend/apps/docs/app/docs/sitemap.ts
@@ -1,6 +1,4 @@
-// biome-ignore lint/correctness/noNodejsModules: This file is used to generate the sitemap and is executed on the server-side only, requiring Node.js modules.
 import fs from 'node:fs'
-// biome-ignore lint/correctness/noNodejsModules: This file is used to generate the sitemap and is executed on the server-side only, requiring Node.js modules.
 import path from 'node:path'
 import type { MetadataRoute } from 'next'
 

diff --git a/frontend/apps/erd-web/next.config.ts b/frontend/apps/erd-web/next.config.ts
@@ -1,4 +1,3 @@
-// biome-ignore lint/correctness/noNodejsModules: This code is only run in the Node.js environment.
 import { execSync } from 'node:child_process'
 import type { NextConfig } from 'next'
 

diff --git a/frontend/packages/cli/biome.jsonc b/frontend/packages/cli/biome.jsonc
@@ -13,9 +13,7 @@
               }
             }
           }
-        },
-        // Due to the unavoidable use of Node.js modules in server-side code.
-        "noNodejsModules": "off"
+        }
       }
     }
   }

diff --git a/frontend/packages/configs/biome.jsonc b/frontend/packages/configs/biome.jsonc
@@ -18,7 +18,6 @@
         "useImportRestrictions": "error"
       },
       "correctness": {
-        "noNodejsModules": "error",
         "noUndeclaredDependencies": "error",
         "noUnusedVariables": "error",
         "noUndeclaredVariables": "error"

diff --git a/frontend/packages/db-structure/biome.jsonc b/frontend/packages/db-structure/biome.jsonc
@@ -8,6 +8,7 @@
   "linter": {
     "rules": {
       "correctness": {
+        "noNodejsModules": "error",
         "useImportExtensions": {
           "level": "error",
           "fix": "safe",

diff --git a/frontend/packages/erd-core/biome.jsonc b/frontend/packages/erd-core/biome.jsonc
@@ -1,3 +1,10 @@
 {
-  "extends": ["../../packages/configs/biome.jsonc"]
+  "extends": ["../../packages/configs/biome.jsonc"],
+  "linter": {
+    "rules": {
+      "correctness": {
+        "noNodejsModules": "error"
+      }
+    }
+  }
 }
diff --git a/frontend/packages/figma-to-css-variables/biome.jsonc b/frontend/packages/figma-to-css-variables/biome.jsonc
@@ -1,11 +1,3 @@
 {
-  "extends": ["../../packages/configs/biome.jsonc"],
-  "linter": {
-    "rules": {
-      "correctness": {
-        // Due to the unavoidable use of Node.js modules in server-side code.
-        "noNodejsModules": "off"
-      }
-    }
-  }
+  "extends": ["../../packages/configs/biome.jsonc"]
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -13,9 +13,7 @@ @@
                   }
                 }
               }
-            },
-            // Due to the unavoidable use of Node.js modules in server-side code.
-            "noNodejsModules": "off"
+            }
           }
         }
       }
@@ Expand Down @@