feat: Introduce edge marker as cardinality icon #319
Merged
+268
−279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasamuku
force-pushed
the
introduce_edge_marker
branch
from
4b34223 to
750e32c
Compare
sasamuku
commented
Dec 19, 2024
Comment on lines
+44
to
+53
| <text | ||
| x="15.5" | ||
| y="-8" | ||
| textAnchor="middle" | ||
| fontSize="8" | ||
| fill="currentColor" | ||
| dominantBaseline="hanging" | ||
| > | ||
| 1 | ||
| </text> |
There was a problem hiding this comment.
📝 includes cardinality notation into SVG marker
sasamuku
force-pushed
the
introduce_edge_marker
branch
from
750e32c to
fde3087
Compare
sasamuku
requested review from
hoshinotsuyoshi,
FunamaYukina,
junkisai and
MH4GF
and removed request for
a team
sasamuku
changed the title
MH4GF
reviewed
Dec 19, 2024
frontend/packages/erd-core/src/components/ERDRenderer/ERDContent/ERDContent.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/erd-core/src/components/ERDRenderer/ERDContent/RelationshipEdge/type.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+42
to
+53
| {isHighlighted && ( | ||
| <text | ||
| x="6" | ||
| y="-9" | ||
| textAnchor="middle" | ||
| fontSize="9" | ||
| fill="currentColor" | ||
| dominantBaseline="hanging" | ||
| > | ||
| n | ||
| </text> | ||
| )} |
MH4GF
approved these changes
Dec 19, 2024
...ackages/erd-core/src/components/ERDRenderer/ERDContent/RelationshipEdge/RelationshipEdge.tsx
Outdated
Show resolved
Hide resolved
sasamuku
force-pushed
the
introduce_edge_marker
branch
from
5e8afa6 to
1a5a94d
Compare
sasamuku
force-pushed
the
introduce_edge_marker
branch
from
1a5a94d to
5065da0
Compare
sasamuku
had a problem deploying
to
preview - @liam-hq/erd-sample
GitHub Actions
Error
sasamuku
force-pushed
the
introduce_edge_marker
branch
from
5065da0 to
a3c895c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
rebuild #311 for production ready.
2024-12-19.17.03.33.mov
highlightedHandleslogic may not be necessary, but it would be good to create another PR.Edge Markers
This PR's key concept is using
Edge Markers.Displaying / Hiding of cardinalities are always linked to edge.
https://reactflow.dev/examples/edges/markers
Related Issue
Changes
Testing
Other Information