Skip to content

Commit

Permalink
refactor: Delete Cardinality icon from TableColumn
Browse files Browse the repository at this point in the history
  • Loading branch information
sasamuku committed Dec 19, 2024
1 parent 31b0b46 commit 750e32c
Show file tree
Hide file tree
Showing 8 changed files with 12 additions and 187 deletions.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -6,23 +6,18 @@ import { DiamondFillIcon, DiamondIcon, KeyRound, Link } from '@liam-hq/ui'
import { Handle, Position } from '@xyflow/react'
import clsx from 'clsx'
import type { FC } from 'react'
import { match } from 'ts-pattern'
import { Cardinality } from './Cardinality'
import { CardinalityNotation } from './CardinalityNotation'
import styles from './TableColumn.module.css'

type TableColumnProps = {
column: Column
handleId: string
isHighlighted: boolean
isSource: boolean
targetCardinality?: CardinalityType | undefined
}

export const TableColumn: FC<TableColumnProps> = ({
column,
handleId,
isHighlighted,
isSource,
targetCardinality,
}) => {
Expand Down Expand Up @@ -71,65 +66,21 @@ export const TableColumn: FC<TableColumnProps> = ({
</span>

{isSource && (
<>
<Handle
id={handleId}
type="source"
position={Position.Right}
className={clsx([styles.handle])}
/>
<Cardinality
direction="right"
cardinality="ONE_TO_ONE"
isHighlighted={isHighlighted}
/>
<CardinalityNotation
direction="right"
notation="1"
isHighlighted={isHighlighted}
/>
</>
<Handle
id={handleId}
type="source"
position={Position.Right}
className={clsx([styles.handle])}
/>
)}

{targetCardinality && (
<>
<Handle
id={handleId}
type="target"
position={Position.Left}
className={clsx([styles.handle])}
/>
{match(targetCardinality)
.with('ONE_TO_ONE', () => (
<>
<Cardinality
direction="left"
cardinality="ONE_TO_ONE"
isHighlighted={isHighlighted}
/>
<CardinalityNotation
direction="left"
notation="1"
isHighlighted={isHighlighted}
/>
</>
))
.with('ONE_TO_MANY', () => (
<>
<Cardinality
direction="left"
cardinality="ONE_TO_MANY"
isHighlighted={isHighlighted}
/>
<CardinalityNotation
direction="left"
notation="n"
isHighlighted={isHighlighted}
/>
</>
))
.otherwise(() => null)}
</>
<Handle
id={handleId}
type="target"
position={Position.Left}
className={clsx([styles.handle])}
/>
)}
</li>
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,13 @@ export const TableColumnList: FC<TableColumnListProps> = ({ data, filter }) => {
return null
}
const handleId = columnHandleId(data.table.name, column.name)
const isHighlighted =
data.isHighlighted || data.highlightedHandles?.includes(handleId)
const isSource = data.sourceColumnName === column.name

return (
<TableColumn
key={column.name}
column={column}
handleId={handleId}
isHighlighted={isHighlighted}
isSource={isSource}
targetCardinality={data.targetColumnCardinalities?.[column.name]}
/>
Expand Down

0 comments on commit 750e32c

Please sign in to comment.