Fixed errors (on aarm64 Macs) and deprecated syntax in C/CPP/TS targets #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhstrh
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
These changes look good to me. Thanks for the fixes, @AneesHl! In a separate PR (to not obfuscate the diff), please run lff on these files to make sure the formatting is correct also. We should add a CI check for that as well (refer to the playground-lingua-franca repo for how to do that).
|
Let's handle the formatting as a separate issue: #62. I can take care of that. |
cmnrd
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
This is amazing work! Thank you for digging into this. This helps considerably with removing the deprecated target properties and syntax rules (lf-lang/lingua-franca#2209, lf-lang/lingua-franca#2202, lf-lang/lingua-franca#1675)
cmnrd
added a commit
to lf-lang/lingua-franca
that referenced
this pull request
Feb 22, 2024
Currently, if the target declarationu uses a property that is not supported by the target, this is reported as a warning. This is problematic, as we and potentially users don't notice if a target property is not supported anymore. For instance, we had several uses of the `flags` property in the C tests although it was renamed. Also the benchmarks used properties that we removed (See lf-lang/benchmarks-lingua-franca#61). This PR converts the warning message into an error, adjusts the unit tests, and fixes some of the C tests. I opted for simply dropping the `flags` property, as apparently it wasn't required and not used for a while. In particular, some tests attempted to avoid optimization, which is not needed as we compile the tests in Debug mode (whithout optimization) anyway.
cmnrd
added a commit
to lf-lang/lingua-franca
that referenced
this pull request
Feb 23, 2024
Currently, if the target declarationu uses a property that is not supported by the target, this is reported as a warning. This is problematic, as we and potentially users don't notice if a target property is not supported anymore. For instance, we had several uses of the `flags` property in the C tests although it was renamed. Also the benchmarks used properties that we removed (See lf-lang/benchmarks-lingua-franca#61). This PR converts the warning message into an error, adjusts the unit tests, and fixes some of the C tests. I opted for simply dropping the `flags` property, as apparently it wasn't required and not used for a while. In particular, some tests attempted to avoid optimization, which is not needed as we compile the tests in Debug mode (whithout optimization) anyway.
cmnrd
added a commit
to lf-lang/lingua-franca
that referenced
this pull request
Feb 23, 2024
Currently, if the target declarationu uses a property that is not supported by the target, this is reported as a warning. This is problematic, as we and potentially users don't notice if a target property is not supported anymore. For instance, we had several uses of the `flags` property in the C tests although it was renamed. Also the benchmarks used properties that we removed (See lf-lang/benchmarks-lingua-franca#61). This PR converts the warning message into an error, adjusts the unit tests, and fixes some of the C tests. I opted for simply dropping the `flags` property, as apparently it wasn't required and not used for a while. In particular, some tests attempted to avoid optimization, which is not needed as we compile the tests in Debug mode (whithout optimization) anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many benchmarks were failing when executed locally on Macs with Apple Silicon. The reasons varied between the usage of incompatible types (
size_tvs.int), typos, missing header imports and deprecated syntax (e.g.int(5)instead ofint=5).Not all benchmarks were failing but I tried extend the improvements to all benchmarks wherever applicable.
However, one benchmark (
PiPrecise) is still failing inC/Cppon Arm Macs, but the reason is unrelated to the improvements in this PR and has to do with how theGMPlibrary/headers are built/included, and would probably be better investigated in a dedicated issue.Fixes #60