Report unsupported target properties as errors #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmnrd
changed the title
|
@erlingrj The Zephyr test fails because it uses the old |
|
Thanks. It was checking out the lf-west-template repo and trying to compile a hello world from there. I have updated it so to remove the use of the threading property: lf-lang/lf-west-template#5 |
|
There are changes in |
lhstrh
reviewed
Feb 23, 2024
|
Thanks for catching this. reactor-c got staged accidentally. |
cmnrd
force-pushed
the
unsupported-properties-as-errors
branch
from
9f82e8a
to
3d63d86
Compare
Currently, if the target declarationu uses a property that is not supported by the target, this is reported as a warning. This is problematic, as we and potentially users don't notice if a target property is not supported anymore. For instance, we had several uses of the `flags` property in the C tests although it was renamed. Also the benchmarks used properties that we removed (See lf-lang/benchmarks-lingua-franca#61). This PR converts the warning message into an error, adjusts the unit tests, and fixes some of the C tests. I opted for simply dropping the `flags` property, as apparently it wasn't required and not used for a while. In particular, some tests attempted to avoid optimization, which is not needed as we compile the tests in Debug mode (whithout optimization) anyway.
cmnrd
force-pushed
the
unsupported-properties-as-errors
branch
from
3d63d86
to
5b5c5e3
Compare
|
Fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the target declaration uses a property that is not supported by the target, this is reported as a warning. This is problematic, as we and potentially users don't notice if a target property is not supported anymore. For instance, we had several uses of the
flagsproperty in the C tests although it was renamed. Also the benchmarks used properties that we removed (See lf-lang/benchmarks-lingua-franca#61).This PR converts the warning message into an error, adjusts the unit tests, and fixes some of the C tests. I opted for simply dropping the
flagsproperty, as apparently it wasn't required and not used for a while. In particular, some tests attempted to avoid optimization, which is not needed as we compile the tests in Debug mode (without optimization) anyway.