Locked dependencies to rc1 or pinned revisions

[ogghead]

This satisfies the first step of #8 with rc1 locked versions

@raskyld @benwis I appreciate reviews when ya'll have time!

[benwis]

We’ve released rc2 with release in a week most likely, so maybe it’s worth waiting?

…

On Fri, Nov 22, 2024, at 2:06 PM, Darwin Boersma wrote: ***@***.**** commented on this pull request. In Cargo.toml <#9 (comment)>: > @@ -8,17 +8,17 @@ version = "0.0.1" edition = "2021" [dependencies] -any_spawner = { git = "https://github.com/leptos-rs/leptos", features = ["futures-executor"] } -throw_error = { git = "https://github.com/leptos-rs/leptos" } -hydration_context = { git = "https://github.com/leptos-rs/leptos" } +any_spawner = { git = "https://github.com/leptos-rs/leptos", rev = "84bdd6b56892cc859b512b0de1dc139f83375f5d" , features = ["futures-executor"] } Indeed, this does work in the leptos-spin template fermyon/leptos-spin#48 <fermyon/leptos-spin#48> -- I tested it by swapping the current pinned commit of leptos_wasi to my branch with `leptos_wasi = { git = "https://github.com/ogghead/leptos_wasi", branch = "rc1-locked-deps", optional = true }` and the Spin app spins up while referring to rc1 versions of Leptos crates — Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVBTCMN7ESSUABWIL6DZLD2B6THJAVCNFSM6AAAAABSJTAQYKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINJVHAZDSMJSGU>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[raskyld]

I think at least using rc2 makes sense to have everything clean and avoid git refs

[ogghead]

I think at least using rc2 makes sense to have everything clean and avoid git refs

Checking into this and upgraded deps to rc2, but I am actually not seeing any release of https://crates.io/crates/any_spawner in the last 5 months. Leptos exports the Executor from any_spawner but not the CustomExecutor used by this crate. It seems that crate might need to be released -- or Leptos might need to reexport that CustomExecutor trait -- before we can move off the git revision locked version of any_spawner

[raskyld]

Good catch! Well I guess we should wait for the definite release which will include your changes so, WDYT?

[ogghead]

Good catch! Well I guess we should wait for the definite release which will include your changes so, WDYT?

Agreed! I can keep an eye out and update this PR with 0.7 dependencies + publish a 0.7 version of this crate after release if that makes sense?