Version any_spawner alongside other crates, reexport CustomExecutor

[ogghead]

This PR proposes a couple options (not mutually exclusive) for how to version new any_spawner functionality in downstream crates:

1. Create an rc2 version of any_spawner to align with leptos crate versions -- leptos_wasi (and potentially others) rely on this crate and currently must use a locked git revision, this comment has more details
2. Reexport CustomExecutor from any_spawner in Leptos -- this allows using the Executor and CustomExecutor directly from Leptos and eliminating any_spawner dependency in downstream crates

[benwis]

I think it makes sense to expose it from Leptos, then you/them won’t have to worry about it till breaking releases. Does that make sense?

…

On Sat, Nov 23, 2024, at 11:02 AM, Darwin Boersma wrote: This PR proposes a couple options (not mutually exclusive) for how to version new any_spawner functionality in downstream crates: 1. Create an rc2 version of any_spawner to align with leptos crate versions -- leptos_wasi <https://github.com/leptos-rs/leptos_wasi> (and potentially others) rely on this crate and currently must use a locked git revision, this comment has more details <leptos-rs/leptos_wasi#9 (comment)> 2. Reexport CustomExecutor from any_spawner in Leptos -- this allows using the Executor and CustomExecutor directly from Leptos and eliminating any_spawner dependency in downstream crates You can view, comment on, or merge this pull request online at: #3284 Commit Summary • 20ffd25 <20ffd25> rc2 version any_spawner File Changes (4 files <https://github.com/leptos-rs/leptos/pull/3284/files>) • *M* Cargo.lock <https://github.com/leptos-rs/leptos/pull/3284/files#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87e> (2) • *M* Cargo.toml <https://github.com/leptos-rs/leptos/pull/3284/files#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542> (2) • *M* any_spawner/Cargo.toml <https://github.com/leptos-rs/leptos/pull/3284/files#diff-404970d4396703e7cd94b08fa19c6019477d548917aa64216cdcf60d3f62d417> (2) • *M* leptos/src/lib.rs <https://github.com/leptos-rs/leptos/pull/3284/files#diff-41e693c7f3b6e94bf25a3ddd1f59464d933f306c45242bc5d568801f2013a0db> (2) Patch Links: • https://github.com/leptos-rs/leptos/pull/3284.patch • https://github.com/leptos-rs/leptos/pull/3284.diff — Reply to this email directly, view it on GitHub <#3284>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVBTCOR2XLJOMLWIED6WWD2CDGNDAVCNFSM6AAAAABSLLM5J6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGY4DMNBUG42TCMI>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[ogghead]

I think it makes sense to expose it from Leptos, then you/them won’t have to worry about it till breaking releases. Does that make sense?

Agreed! This PR reexports CustomExecutor and Executor -- do you think it would be better to reexport the full any_spawner crate or does this reexport make sense?

[benwis]

Can you think of anything else y’all might need? Reexporting the whole thing would protect against that

…

On Sat, Nov 23, 2024, at 11:13 AM, Darwin Boersma wrote: > I think it makes sense to expose it from Leptos, then you/them won’t have to worry about it till breaking releases. Does that make sense? > Agreed! This PR reexports `CustomExecutor` and `Executor` -- do you think it would be better to reexport the full any_spawner crate or does this reexport make sense? — Reply to this email directly, view it on GitHub <#3284 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVBTCJJ3QXS3OTTGFITFW32CDHXHAVCNFSM6AAAAABSLLM5J6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJVGYZDKNJTGM>. You are receiving this because you commented.Message ID: ***@***.***>

[ogghead]

I was able to get leptos_wasi building with just those two exported (and local path dep on some leptos crates) so I am fairly sure this is the bare minimum reexports needed, but definitely open to reexporting the full crate if that's preferable!

[benwis]

In my opinion it'll save us pain later in case someone else needs something

[ogghead]

Makes sense to me! I appreciate the quick review on this. Updated with the full reexport now