Implementing mute feature; Updated example and readme #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
adding 'solo' feature which stop all other playing sounds
|
Thanks for adding this! It seems like this PR includes changes for the "solo" feature, can you clean it up so that it only handles muting the sound? |
leoasis
reviewed
Mar 29, 2019
| @@ -190,7 +208,8 @@ export default class Sound extends React.Component { | |||
| }, | |||
| onbufferchange() { | |||
| instance.props.onBufferChange(this.isBuffering); | |||
| } | |||
| }, | |||
| muted: instance.props.muted, | |||
There was a problem hiding this comment.
Can we move the properties to the top and leave functions at the end?
added 3 commits
April 29, 2020 11:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.