Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mute feature? #78

Open
dkadrios opened this issue Mar 11, 2019 · 2 comments
Open

Mute feature? #78

dkadrios opened this issue Mar 11, 2019 · 2 comments

Comments

@dkadrios
Copy link

Any chance of there being a mute property that's independent of the volume setting? Right now I have to use external state to remember the last volume setting and then set the actual volume to zero in order to mute. This adds overhead and a bit of complexity when displaying volume controls. It'd be great if react-sound took care of handling mute internally. I presume mute is a common enough feature.
@dkadrios
Copy link
Author

Ah, I just noticed @frank780117 has added this in commit frank780117@a2b552c

It's sure would be great to get a PR for that feature! :)

@dkadrios
Copy link
Author

Turned out that the PR from frank780117 was incomplete.

I've submitted a PR that fully implements the mute feature in #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dkadrios