Yann/feature/ble/deep sleep in advertising data #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YannLocatelli
force-pushed
the
yann/feature/ble/deep-sleep-in-advertising-data
branch
from
5cfacc4 to
fffd3ca
Compare
📈 Changes Impact Analysis Report📌 Info
🤖 Firmware impact analysis
Click to show memory sections🔬 Detailed impact analysisClick to show detailed analysis for all targets
🗺️ Map files diff output
|
📈 Changes Impact Analysis Report📌 Info
🤖 Firmware impact analysis
Click to show memory sections🔬 Detailed impact analysisClick to show detailed analysis for all targets
🗺️ Map files diff output
|
|
🔖 Version comparison
|
ladislas
reviewed
Aug 26, 2024
Comment on lines
16
to
+19
| uint8_t version_major {}; | ||
| uint8_t version_minor {}; | ||
| uint16_t version_revision {}; | ||
| uint8_t is_deep_sleeping {}; |
There was a problem hiding this comment.
Suggested change
| uint8_t version_major {}; | |
| uint8_t version_minor {}; | |
| uint16_t version_revision {}; | |
| uint8_t is_deep_sleeping {}; | |
| uint8_t is_deep_sleeping {}; | |
| uint8_t version_major {}; | |
| uint8_t version_minor {}; | |
| uint16_t version_revision {}; |
ladislas
requested changes
Aug 26, 2024
Comment on lines
+32
to
+39
| _internal_values = { | ||
| battery, | ||
| is_charging, | ||
| version_major, | ||
| version_minor, | ||
| static_cast<uint8_t>(version_revision >> 8), | ||
| static_cast<uint8_t>(version_revision), | ||
| is_deep_sleeping, |
There was a problem hiding this comment.
Suggested change
| _internal_values = { | |
| battery, | |
| is_charging, | |
| version_major, | |
| version_minor, | |
| static_cast<uint8_t>(version_revision >> 8), | |
| static_cast<uint8_t>(version_revision), | |
| is_deep_sleeping, | |
| _internal_values = { | |
| battery, | |
| is_charging, | |
| is_deep_sleeping, | |
| version_major, | |
| version_minor, | |
| static_cast<uint8_t>(version_revision >> 8), | |
| static_cast<uint8_t>(version_revision), |
ladislas
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.