Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cai_Wang_2017 Updated and Ready for Review #26

Merged
merged 6 commits into from
Dec 1, 2023
Merged

Conversation

ScottKalberer
Copy link
Collaborator

The gene function file Cai_Wang_2017, originally created by Marlene Dorneich-Hayes, has been updated by Scott Kalberer and is ready for review and merger with the Main branch.

StevenCannon-USDA and others added 6 commits August 31, 2023 10:55
…single gene name for each of these fields)
SYMRK gene in Phaseolus vulgaris
This is a Vigna radiata gene which was studied in transgenic Arabidopsis.  Many of its suspected functions have not been experimentally validated.
Copy link
Collaborator

@StevenCannon-USDA StevenCannon-USDA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some misplaced files (for Phaseolus and Vigna), and some yaml errors in those two files and in one of Wei's). I have fixed those errors and will approve and merge.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For phavu_Davila-Delgado_Flores-Canul_2023, yamllint (run locally) tells me:
1:1 warning missing document start "---" (document-start)
2:4 error syntax error: found character '\t' that cannot start any token (syntax)

Also, the file should have a ".yml" suffix ... and should be in a new directory (rather than at the root level). That is:
Phaseolus/vulgaris/wip_scott/ or Phaseolus/vulgaris/wip_marlene/

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be in a new directory: Vigna/radiata/wip_marlene
The file should have a ".yml" extension, and it needs "---" at the top.

@StevenCannon-USDA StevenCannon-USDA merged commit 0da18ef into main Dec 1, 2023
1 of 2 checks passed
@StevenCannon-USDA StevenCannon-USDA deleted the marlene branch December 1, 2023 16:30
@StevenCannon-USDA StevenCannon-USDA restored the marlene branch December 1, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants