Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated parameters from patrolTest #1892

Merged
merged 5 commits into from
Nov 13, 2023
Merged

Remove deprecated parameters from patrolTest #1892

merged 5 commits into from
Nov 13, 2023

Conversation

jBorkowska
Copy link
Collaborator

@jBorkowska jBorkowska commented Nov 13, 2023 •
edited by bartekpacia
Loading

Closes #1624 and closes #1369

@github-actions github-actions bot added package: patrol Related to the patrol package (native automation, test bundling) package: patrol_cli Related to the patrol_cli package labels Nov 13, 2023
@jBorkowska jBorkowska changed the base branch from master to task/patrol-extension November 13, 2023 10:41
@github-actions github-actions bot removed the package: patrol_cli Related to the patrol_cli package label Nov 13, 2023
mateuszwojtczak
mateuszwojtczak approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@mateuszwojtczak mateuszwojtczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bartekpacia
bartekpacia approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@bartekpacia bartekpacia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.

For the record: the 3 failing patrol_finders tests will be fixed in a separate PR.

@jBorkowska jBorkowska force-pushed the task/remove-deprecated-params branch from 021d1a3 to 32172e3 Compare November 13, 2023 11:31
@jBorkowska jBorkowska force-pushed the task/remove-deprecated-params branch from 32172e3 to 4d581f6 Compare November 13, 2023 11:37
@jBorkowska jBorkowska merged commit dc73453 into task/patrol-extension Nov 13, 2023
5 of 8 checks passed
@jBorkowska jBorkowska deleted the task/remove-deprecated-params branch November 13, 2023 12:01
This was referenced Nov 13, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszwojtczak mateuszwojtczak mateuszwojtczak approved these changes

@bartekpacia bartekpacia bartekpacia approved these changes

@piotruela piotruela Awaiting requested review from piotruela

@zltnDC zltnDC Awaiting requested review from zltnDC

Assignees
No one assigned
Labels
package: patrol Related to the patrol package (native automation, test bundling)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consequences of PatrolFinders
3 participants
@jBorkowska @bartekpacia @mateuszwojtczak