Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consequences of PatrolFinders #1624

Closed
zltnDC opened this issue Aug 10, 2023 · 3 comments · Fixed by #1892
Closed

Consequences of PatrolFinders #1624

zltnDC opened this issue Aug 10, 2023 · 3 comments · Fixed by #1892
Assignees
Labels
tech debt Something needs a refactor

Comments

@zltnDC
Copy link
Contributor

zltnDC commented Aug 10, 2023

We've extracted PatrolTester into a new package and we don't want to release another major version of the patrol package, so we need to avoid breaking changes. This issue collects small things that we may change in the future.

  1. Delete typedef PatrolTester
  2. patrolTest will always initialize NativeAutomator, so we can replace these lines of code in PatrolIntegrationTester:
final NativeAutomator? nativeAutomator;
NativeAutomator get native;

to

final NativeAutomator native;

or

final NativeAutomator nativeAutomator;
NativeAutomator get native => nativeAutomator;
  1. Remove the nativeAutomation argument from the patrolTest() function
@bartekpacia
Copy link
Contributor

not exactly related to this issue but let's remember about #1369 when we'll be releasing breaking changes.

@bartekpacia
Copy link
Contributor

Done in #1892.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar problem, please file a new issue. Make sure to follow the template and provide all the information necessary to reproduce the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tech debt Something needs a refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants