Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patrol CLI: fix generated test bundle being garbled on Windows #1797

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Patrol CLI: fix generated test bundle being garbled on Windows #1797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a640278
Removing first slash, closes #1428
Guillergood Oct 11, 2023
2f8fad4
Formatted packages\patrol_cli\lib\src\test_bundler.dart
Guillergood Oct 11, 2023
dffb6c5
Update CHANGELOG.md
Guillergood Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/patrol_cli/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## Unreleased

- Fix bug with `test_bundle.dart` being sometimes garbled on Windows (#1797)

## 2.2.0

- Add support for `group()` (#1634)
Expand Down
5 changes: 4 additions & 1 deletion packages/patrol_cli/lib/src/test_bundler.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,10 @@ ${generateGroupsCode([testFilePath]).split('\n').map((e) => ' $e').join('\n')}
for (final testFilePath in testFilePaths) {
final relativeTestFilePath = _normalizeTestPath(testFilePath);
final testName = _createTestName(relativeTestFilePath);
imports.add("import '$relativeTestFilePath' as $testName;");
final relativeTestFilePathWithoutSlash = relativeTestFilePath[0] == '/'
? relativeTestFilePath.replaceFirst('/', '')
: relativeTestFilePath;
imports.add("import '$relativeTestFilePathWithoutSlash' as $testName;");
}

return imports.join('\n');
Expand Down
Loading