Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patrol CLI: fix generated test bundle being garbled on Windows #1797

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Patrol CLI: fix generated test bundle being garbled on Windows #1797

merged 3 commits into from
Oct 12, 2023

Conversation

Guillergood
Copy link
Contributor

@Guillergood Guillergood commented Oct 11, 2023

Fixes #1428

@github-actions github-actions bot added the package: patrol_cli Related to the patrol_cli package label Oct 11, 2023
@Guillergood
Copy link
Contributor Author

Guillergood commented Oct 11, 2023

With this PR, I think we can solve #1428 as also I am suffering 😄.

@bartekpacia
Copy link
Contributor

Hi @Guillergood, thanks for the PR!

Please run dart format so satisfy the CI.

Also, have you verified it indeed works fine on Windows machines?

@Guillergood
Copy link
Contributor Author

Guillergood commented Oct 11, 2023

Hi @Guillergood, thanks for the PR!

Please run dart format so satisfy the CI.

Also, have you verified it indeed works fine on Windows machines?

Hello @bartekpacia, I have just committed the format.
Yes, I have tested it with my own projects, and it is working fine.
Also, I strongly believe that it should work for other platforms as if it does not have the slash, the import will suppose that it is in the 'integration_test' folder.
Are we late to have this as a hacktoberfest PR?

@bartekpacia
Copy link
Contributor

Are we late to have this as a hacktoberfest PR?

This repo has the hacktoberfest badge, isn't that for this PR to count?

@bartekpacia
Copy link
Contributor

I verified this PR locally on macOS – ran patrol test in our example app, and it works fine.

@bartekpacia
Copy link
Contributor

bartekpacia commented Oct 12, 2023

Please also modify packages/patrol_cli/CHANGELOG.md with:

## Unreleased

- Fix bug with `test_bundle.dart` being sometimes garbled on Windows (#1797)

## 2.2.0

- ...

@Guillergood
Copy link
Contributor Author

Are we late to have this as a hacktoberfest PR?

This repo has the hacktoberfest badge, isn't that for this PR to count?

Oh, I think as soon as you merge it will count!

@Guillergood
Copy link
Contributor Author

Please also modify packages/patrol_cli/CHANGELOG.md with:

## Unreleased

- Fix bug with `test_bundle.dart` being sometimes garbled on Windows (#1797)

## 2.2.0

- ...

Aye aye, captain! 😄

@bartekpacia bartekpacia changed the title Removing first slash, closes #1428 Patrol CLI: fix generated test bundle being garbled on Windows Oct 12, 2023
@bartekpacia
Copy link
Contributor

I tested it on a Windows machine and on a Mac - works fine everywhere. Merging.

@bartekpacia bartekpacia merged commit 229f76a into leancodepl:master Oct 12, 2023
9 of 11 checks passed
@bartekpacia
Copy link
Contributor

Thank you very much 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: patrol_cli Related to the patrol_cli package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated test bundle is broken on Patrol 2.0 on Windows
2 participants